Page MenuHomePhabricator
Create Task
Maniphest T189113

'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive'
Closed, ResolvedPublic
Actions

Description

Icon displayed on Content Translation Stats, inside personal menu, for anonymous users, is missing the Apex theme version.
The icon is userInactive. You can see here that icon is missing. Here is how that looks in context:

no-anonymous-icon-on-monobook.PNG (43×257 px, 1 KB)

For comparison, here is the look on WikimediaUI theme:
anonymous-icon-on-vector.PNG (56×256 px, 2 KB)

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.28.0mediawiki/coremaster+314 -321
[BREAKING CHANGE] icons: Remove deprecated 'userActive'/'userInactive'oojs/uimaster+0 -16
Replace 'userInactive' with 'userAnonymous'mediawiki/extensions/ContentTranslationmaster+2 -2
icons: Add 'userAnonymous', and deprecate 'userActive'/'userInactive'oojs/uimaster+35 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Petar.petkovic created this task.Mar 7 2018, 12:35 PM
matmarex added a subtask: T169890: Replace Apex icons with WikimediaUI icons.Mar 7 2018, 11:16 PM
gerritbot subscribed.Mar 26 2018, 3:55 AM

Change 421781 had a related patch set uploaded (by VolkerE; owner: Esanders):
[oojs/ui@master] Replace Apex icon set with WMUI icon set

https://gerrit.wikimedia.org/r/421781

gerritbot added a project: Patch-For-Review.Mar 26 2018, 3:55 AM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Mar 26 2018, 4:08 AM
matmarex subscribed.Mar 27 2018, 5:42 PM

Hmm, per the comments on T190441, it seems like we actually want to remove this icon? It has not been redrawn with the recent icon redesign either…

Volker_E added a comment.Mar 27 2018, 7:13 PM

@matmarex There's a replacement in M229, but it will be called 'userAnonymous' and 'userInactive' will act in the beginning as copy.

Volker_E triaged this task as Medium priority.Mar 27 2018, 11:23 PM
gerritbot added a comment.Mar 27 2018, 11:27 PM

Change 422353 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Add 'userAnonymous' and deprecate 'userInactive'

https://gerrit.wikimedia.org/r/422353

Volker_E renamed this task from 'userInactive' icon not available on Apex theme to 'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive'.Mar 27 2018, 11:29 PM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Mar 28 2018, 9:49 PM

Change 422353 merged by jenkins-bot:
[oojs/ui@master] icons: Add 'userAnonymous', and deprecate 'userActive'/'userInactive'

https://gerrit.wikimedia.org/r/422353

Volker_E moved this task from Unsorted to OOUI on the UI-Standardization board.Mar 28 2018, 9:53 PM
Volker_E updated the task description. (Show Details)Mar 28 2018, 10:02 PM
Volker_E updated the task description. (Show Details)Mar 28 2018, 10:13 PM

Can I leave replacing 'userInactive' after v0.26.2 to you, @Petar.petkovic?

• Petar.petkovic added a comment.Mar 28 2018, 10:16 PM
In T189113#4089560, @Volker_E wrote:

Can I leave replacing 'userInactive' after v0.26.2 to you, @Petar.petkovic?

Yes, of course. I was planning to wait for v0.26.2 and update icon.

gerritbot added a comment.Apr 4 2018, 11:25 PM

Change 424163 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Replace 'userInactive' with 'userAnonymous'

https://gerrit.wikimedia.org/r/424163

Jdforrester-WMF updated the task description. (Show Details)Apr 4 2018, 11:28 PM
Jdforrester-WMF moved this task from Reviewing to Waiting for breaking release on the OOUI board.
gerritbot added a comment.Apr 4 2018, 11:37 PM

Change 424163 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Replace 'userInactive' with 'userAnonymous'

https://gerrit.wikimedia.org/r/424163

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 5 2018, 12:00 AM
Volker_E closed subtask T169890: Replace Apex icons with WikimediaUI icons as Resolved.Apr 10 2018, 6:26 PM
matmarex closed this task as Resolved.Apr 12 2018, 2:53 PM
Jdforrester-WMF reopened this task as Open.Apr 12 2018, 3:09 PM
Jdforrester-WMF subscribed.

Not fully Resolved yet, it's not yet removed from OOUI.

• Petar.petkovic removed a project: Patch-For-Review.Apr 12 2018, 4:54 PM
Pginer-WMF removed a project: ContentTranslation.Apr 25 2018, 3:47 PM
matmarex unsubscribed.Apr 25 2018, 8:13 PM
gerritbot added a comment.May 23 2018, 11:33 PM

Change 434825 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [BREAKING CHANGE] icons: Remove deprecated 'userActive'/'userInactive'

https://gerrit.wikimedia.org/r/434825

gerritbot added a project: Patch-For-Review.May 23 2018, 11:33 PM
Volker_E updated the task description. (Show Details)May 23 2018, 11:33 PM
Jdforrester-WMF moved this task from Waiting for breaking release to OOUI-0.28.0 on the OOUI board.Aug 13 2018, 6:16 PM
Jdforrester-WMF edited projects, added OOUI (OOUI-0.28.0); removed OOUI.
gerritbot added a comment.Aug 13 2018, 6:27 PM

Change 434825 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] icons: Remove deprecated 'userActive'/'userInactive'

https://gerrit.wikimedia.org/r/434825

• Petar.petkovic removed a project: Patch-For-Review.Aug 13 2018, 7:41 PM
Volker_E closed this task as Resolved.Aug 13 2018, 9:30 PM
Volker_E claimed this task.
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Aug 15 2018, 12:09 AM

Change 452872 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

gerritbot added a project: Patch-For-Review.Aug 15 2018, 12:09 AM
gerritbot added a comment.Aug 15 2018, 5:56 PM

Change 452872 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

• Petar.petkovic removed a project: Patch-For-Review.Aug 15 2018, 6:13 PM
• Petar.petkovic removed a subscriber: gerritbot.
Jdforrester-WMF added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 15 2018, 7:23 PM

The OOUI release landed in MediaWiki 1.32.0-wmf.18.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits