| santhosh | |
| Apr 4 2018, 6:02 AM |
| F16654856: image.png | |
| Apr 4 2018, 6:02 AM |
| F16654816: image.png | |
| Apr 4 2018, 6:02 AM |
cxserver auto adapts galleries to target language. It machine translates the image captions, adapts Image namespaces. The adapted gallery works fine with VisualEditor, except the rendering in translation column has blank images:
| Actual result: | Expected result |
 |  |
This will also resolve:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add img.src's to gallery DM output | mediawiki/extensions/VisualEditor | master | +1 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T102107 Enable Content Translation in Catalan Wikipedia for all logged-in users | |||
| Open | None | T102964 [Epic] Better support for templates in Content Translation | |||
| Open | None | T191389 CX2: Content type support (tracker) | |||
| Resolved | Esanders | T191377 CX2: Support gallery |
The reason for missing images is, ve.dm.MWGalleryImageNode.static.toDomElements does not add src attribute to img tags. This gallery html without src attributes get machine translated and adapted and placed in translation column. It produce valid wiki markup, except cause blank images when displayed.
The following one line change in ve.dm.MWGalleryImageNode.js resolves the issue.
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js b/modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js index dca2bb59a..3fab066b2 100644 --- a/modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js +++ b/modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js @@ -105,6 +105,7 @@ ve.dm.MWGalleryImageNode.static.toDomElements = function ( data, doc ) { // a.setAttribute( 'href', model.attributes.src ); img.setAttribute( 'resource', model.attributes.resource ); + img.setAttribute( 'src', model.attributes.src ); if ( alt ) { img.setAttribute( 'alt', alt ); }
@Esanders, is this change acceptable at VE or should we subclass ve.dm.MWGalleryImageNode in CX?
Change 424279 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Add img.src's to gallery DM output
Change 424279 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add img.src's to gallery DM output