Maniphest T191737

Bundle Scribunto extension with MediaWiki
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	CCicalese_WMF
	Apr 8 2018, 6:25 PM

Description

Passed security review or already Wikimedia deployed
Voting CI structure tests
Runs MediaWiki-CodeSniffer
Runs phan
Supports MySQL, SQLite, and Postgres (no schema changes)
GPL v2 or later compatible license
Extension's default configuration provides optimal experience
Tested with web installer

Details

	Subject	Repo	Branch	Lines +/-
	make-release: Include Scribunto in 1.34+	mediawiki/tools/release	master	+1 -0
	Use CodeEditor and SyntaxHighlight when available	mediawiki/extensions/Scribunto	master	+5 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T194266 Expand the set of bundled skins
Invalid	None	T178349 Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites
Resolved	None	T209220 Expand the set of bundled extensions and skins in MediaWiki 1.34
Resolved	Jdforrester-WMF	T191737 Bundle Scribunto extension with MediaWiki
Resolved	CCicalese_WMF	T109873 Scribunto uses deprecated SyntaxHighlight_GeSHi methods

Event Timeline

CCicalese_WMF created this task.Apr 8 2018, 6:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2018, 6:25 PM

CCicalese_WMF added a parent task: T178349: Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites.Apr 8 2018, 6:28 PM

Tgr subscribed.Apr 8 2018, 8:56 PM

Legoktm removed a project: MediaWiki-Installer.Apr 9 2018, 1:38 AM

Legoktm updated the task description. (Show Details)Apr 9 2018, 2:20 AM

While Scribunto does not require CodeEditor, if both are enabled, the following should probably be set:

$wgScribuntoUseCodeEditor = true;

Similarly, Scribunto does not require SyntaxHighlight, but if both are enabled, the following should probably be set:

$wgScribuntoUseGeSHi = true;

Change 425015 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/Scribunto@master] Use CodeEditor and SyntaxHighlight when available

https://gerrit.wikimedia.org/r/425015

gerritbot added a project: Patch-For-Review.Apr 9 2018, 8:59 AM

Change 425015 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Use CodeEditor and SyntaxHighlight when available

https://gerrit.wikimedia.org/r/425015

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 9 2018, 1:01 PM

cicalese added a project: Scribunto.Apr 17 2018, 12:23 AM

There are two deprecation warnings in Scribunto when used with SyntaxHighlight:

Deprecated: Use of SyntaxHighlight::prepare is deprecated. [Called from ScribuntoContent::fillParserOutput in /WIKIFARM/MEDIAWIKI/mediawiki-master/extensions/Scribunto/includes/common/ScribuntoContent.php at line 128] in /WIKIFARM/MEDIAWIKI/mediawiki-master/includes/debug/MWDebug.php on line 309

Deprecated: Use of SyntaxHighlight::buildHeadItem is deprecated. [Called from ScribuntoContent::fillParserOutput in /WIKIFARM/MEDIAWIKI/mediawiki-master/extensions/Scribunto/includes/common/ScribuntoContent.php at line 141] in /WIKIFARM/MEDIAWIKI/mediawiki-master/includes/debug/MWDebug.php on line 309

Legoktm added a subtask: T109873: Scribunto uses deprecated SyntaxHighlight_GeSHi methods.Apr 17 2018, 8:43 PM

License review: I talked with @lfaraone (Debian FTP master) and he's concerned about the lua 5.1 binaries that are included with Scribunto. Are the Windows/macOS binaries fully free software (are they linked with any proprietary Windows/macOS library)? I think I read somewhere that @Anomie used centos with an old glibc to build the Linux binaries so that should all be free software.

T72541#1805584 and subsequent comments describe the build process used.

The "generic" build target doesn't statically link anything and only dynamically links libm, and the instructions for building on Windows don't specify linking against anything at all, although in any case I suppose it'll also link with the equivalent of libc.

I have no idea how to determine whether the binaries are "fully" free software in the face of dynamic linking. It seems even actual lawyers disagree.

CCicalese_WMF closed subtask T109873: Scribunto uses deprecated SyntaxHighlight_GeSHi methods as Resolved.Apr 18 2018, 6:21 PM

CCicalese_WMF updated the task description. (Show Details)

• demon moved this task from Backlog to Extension bundling on the MW-1.31-release board.Apr 26 2018, 7:32 PM

Legoktm updated the task description. (Show Details)May 15 2018, 3:11 PM

CCicalese_WMF renamed this task from Bundle Scribunto extension with MW 1.31 to Bundle Scribunto extension with MW 1.32.Jun 7 2018, 3:55 PM

CCicalese_WMF edited parent tasks, added: T196650: Expand the set of bundled extensions and skins in MediaWiki 1.32; removed: T178349: Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites.

CCicalese_WMF edited projects, added MW-1.32-release; removed MW-1.31-release.

MGChecker subscribed.Sep 2 2018, 7:51 PM

No open patchsets FWICS.

Legoktm moved this task from Backlog to Bundling additions on the MW-1.32-release board.Oct 9 2018, 12:40 AM

Anomie moved this task from Backlog to External on the Scribunto board.Oct 22 2018, 6:01 PM

CCicalese_WMF renamed this task from Bundle Scribunto extension with MW 1.32 to Bundle Scribunto extension with MediaWiki.Nov 10 2018, 6:49 PM

CCicalese_WMF mentioned this in T209220: Expand the set of bundled extensions and skins in MediaWiki 1.34.Nov 10 2018, 6:58 PM

CCicalese_WMF edited parent tasks, added: T209220: Expand the set of bundled extensions and skins in MediaWiki 1.34; removed: T196650: Expand the set of bundled extensions and skins in MediaWiki 1.32.Nov 10 2018, 7:03 PM

CCicalese_WMF edited projects, added MW-1.33-release; removed MW-1.32-release.Nov 21 2018, 3:06 PM

MGChecker moved this task from Backlog to Bundling additions on the MW-1.33-release board.Dec 21 2018, 9:27 AM

Jdforrester-WMF edited projects, added MW-1.34-release; removed MW-1.33-release.Jun 7 2019, 9:00 PM

Krinkle moved this task from Blocker to Bundling additions on the MW-1.34-release board.Jun 15 2019, 12:28 AM

Any update on the license question?

Krinkle removed a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Sep 13 2019, 4:44 PM

CCicalese_WMF triaged this task as Medium priority.Sep 13 2019, 4:48 PM

Ping WMF-Legal? I don't see there being an answer to that question until an actual tech lawyer steps up. And it wouldn't surprise me much if two different lawyers gave two (or more) different opinions, so even that might not help.

And even if our lawyers tell us it's ok, Debian may well decide differently and strip out the Windows and Mac binaries from their package anyway. Which wouldn't really be a bad thing, since Debian users aren't going to need those binaries anyway and people who do need them aren't at all likely to get MediaWiki from Debian.

I think it's reasonable to proceed and let Debian do what they may.

Change 536690 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/tools/release@master] make-release: Include Scribunto in 1.34+

https://gerrit.wikimedia.org/r/536690

gerritbot added a project: Patch-For-Review.Sep 13 2019, 9:15 PM