Page MenuHomePhabricator
Create Task
Maniphest T198032

Persistently storing a new Sense
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

As an editor I want to be able to make and edit that persists over reloads and is visible to other editors in order to make meaningful contributions.

Problem:
Currently when saving a newly added Sense on a Lexeme it looks like it is saved but when you reload the page it is gone.

Acceptance criteria:

  • When reloading the page the Sense I added before the reload is still there.

BDD
GIVEN I am on a Lexeme page
AND I add a new Sense
WHEN I reload the page
THEN the new Sense is still there

Details

SubjectRepoBranchLines +/-
Do not color code glossesmediawiki/extensions/WikibaseLexememaster+1 -6
Add Lexeme::addOrUpdateSense()mediawiki/extensions/WikibaseLexememaster+31 -0
Add BlankSense, DummySenseId, NullSenseIdmediawiki/extensions/WikibaseLexememaster+317 -4
Add Lexeme::addSense() and Lexeme::removeSense()mediawiki/extensions/WikibaseLexememaster+97 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lydia_Pintscher created this task.Jun 24 2018, 10:58 AM
Lydia_Pintscher moved this task from incoming to features/bugs for next release (Senses) on the Wikidata Lexicographical data board.Jun 24 2018, 11:17 AM
• RazShuty set the point value for this task to 8.Jun 26 2018, 11:10 AM
• Vvjjkkii renamed this task from Persistently storing a new Sense to feaaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
CommunityTechBot renamed this task from feaaaaaaaa to Persistently storing a new Sense.Jul 2 2018, 10:25 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot set the point value for this task to 8.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
• RazShuty added a project: Wikidata-Senses-Iteration1.Jul 3 2018, 11:39 AM
gerritbot subscribed.Jul 10 2018, 3:42 PM

Change 444899 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add Lexeme::addSense() and Lexeme::removeSense()

https://gerrit.wikimedia.org/r/444899

gerritbot added a project: Patch-For-Review.Jul 10 2018, 3:42 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE99c7d70b79f7: Add Lexeme::addSense() and Lexeme::removeSense().Jul 10 2018, 3:45 PM
gerritbot added a comment.Jul 10 2018, 4:22 PM

Change 444904 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add BlankSense, DummySenseId, NullSenseId

https://gerrit.wikimedia.org/r/444904

gerritbot added a comment.Jul 10 2018, 4:22 PM

Change 444905 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add Lexeme::addOrUpdateSense()

https://gerrit.wikimedia.org/r/444905

Lucas_Werkmeister_WMDE mentioned this in rEWLE3883944157d1: Add Lexeme::addSense() and Lexeme::removeSense().Jul 10 2018, 4:22 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE303203f601f6: Add BlankSense, DummySenseId, NullSenseId.
Lucas_Werkmeister_WMDE mentioned this in rEWLE5e9c8cd81cb7: Add Lexeme::addOrUpdateSense().
Lucas_Werkmeister_WMDE mentioned this in rEWLE08fde125760d: Add Lexeme::addOrUpdateSense().Jul 10 2018, 4:37 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEe2f017e3bd14: Add BlankSense, DummySenseId, NullSenseId.
gerritbot added a comment.Jul 10 2018, 6:25 PM

Change 444899 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add Lexeme::addSense() and Lexeme::removeSense()

https://gerrit.wikimedia.org/r/444899

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 11 2018, 12:01 AM
gerritbot added a comment.Jul 11 2018, 11:10 AM

Change 444904 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add BlankSense, DummySenseId, NullSenseId

https://gerrit.wikimedia.org/r/444904

Addshore mentioned this in rEWLE195ca7f45126: Add Lexeme::addOrUpdateSense().Jul 12 2018, 8:45 AM
Addshore moved this task from To Do to Doing on the Wikidata-Senses-Iteration1 board.Jul 12 2018, 11:42 AM
Lucas_Werkmeister_WMDE mentioned this in rEWLEb5db2d73b657: Add Lexeme::addOrUpdateSense().Jul 16 2018, 10:30 AM
Lucas_Werkmeister_WMDE mentioned this in rEWLEd77c80db8421: Add Lexeme::addOrUpdateSense().
Lucas_Werkmeister_WMDE closed subtask T198198: Load/show stored senses when loading a lexeme page as Resolved.Jul 16 2018, 1:16 PM
hoo closed subtask T199244: Add support for deserializing senses as Resolved.Jul 16 2018, 6:07 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEb90849730130: Add Lexeme::addOrUpdateSense().Jul 17 2018, 10:21 AM
gerritbot added a comment.Jul 17 2018, 11:20 AM

Change 444905 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add Lexeme::addOrUpdateSense()

https://gerrit.wikimedia.org/r/444905

Ladsgroup subscribed.Jul 17 2018, 8:04 PM

@Lydia_Pintscher This is actually testable in beta cluster now. The UI needs some polish but overall it works.

Ladsgroup added a comment.Jul 17 2018, 8:06 PM

https://wikidata.beta.wmflabs.org/w/index.php?title=Lexeme:L5&diff=1041639&oldid=1015099

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)); removed MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 18 2018, 5:01 AM
Lydia_Pintscher added a comment.Jul 18 2018, 7:53 PM

Yay :)
Indeed we have to clean it up a bit still but yay!

Lucas_Werkmeister_WMDE closed subtask T198196: Add wbladdsense API action to create a new sense for a lexeme as Resolved.Jul 23 2018, 10:23 AM
Lucas_Werkmeister_WMDE closed subtask T198197: Make senses UI call wbladdsense API when saving a new sense as Resolved.
WMDE-leszek added a project: Wikidata-Senses-Iteration2.Jul 24 2018, 11:39 AM
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Wikidata-Senses-Iteration2 board.Jul 24 2018, 11:40 AM
Ladsgroup moved this task from Doing to Test (Product Review) on the Wikidata-Senses-Iteration2 board.Jul 24 2018, 12:52 PM
Lucas_Werkmeister_WMDE closed subtask T200033: Clean up the UI for adding a new sense as Resolved.Jul 24 2018, 4:46 PM
Lydia_Pintscher added a comment.Jul 26 2018, 3:54 PM

Wohoooooo! This is starting to take shape \o/
One small thing I hope we can still solve in this ticket: The second Gloss of a Sense is gray instead of black. This implies that one is "better/more important/..." than the others, which is not the case. Can we remove the difference in styling?

Screenshot_20180726_175225.png (248×1 px, 16 KB)

gerritbot added a comment.Jul 26 2018, 3:59 PM

Change 448061 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Do not color code glosses

https://gerrit.wikimedia.org/r/448061

Ladsgroup mentioned this in rEWLE06dc743b00c5: Do not color code glosses.Jul 26 2018, 4:00 PM
Ladsgroup mentioned this in rEWLEd4d27203dced: Do not color code glosses.Jul 26 2018, 4:03 PM
gerritbot added a comment.Jul 27 2018, 10:04 AM

Change 448061 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Do not color code glosses

https://gerrit.wikimedia.org/r/448061

hoo removed a project: Patch-For-Review.Jul 27 2018, 10:14 AM
hoo subscribed.

AFAICT this is fully done now.

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)); removed MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 27 2018, 11:00 AM
Lydia_Pintscher closed this task as Resolved.Jul 30 2018, 2:40 PM
Lydia_Pintscher claimed this task.
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration2 board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits