Maniphest T199095

Add SenseSet class
Closed, ResolvedPublic
Actions

Description

Similar to FormSet, a SenseSet stores a set of Senses, ensures that no two senses share the same ID, and tracks the highest sense ID used in the set.

Details

	Subject	Repo	Branch	Lines +/-
	Use SenseSet in Lexeme	mediawiki/extensions/WikibaseLexeme	master	+40 -38
	Add SenseSet class	mediawiki/extensions/WikibaseLexeme	master	+282 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T196162 Adding a new Sense
Resolved	Lea_Lacroix_WMDE	T198033 Persistent IDs for Senses
Resolved	Lucas_Werkmeister_WMDE	T199095 Add SenseSet class

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 9 2018, 11:10 AM

Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Wikidata-Senses-Iteration1 board.

Change 444569 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add SenseSet class

https://gerrit.wikimedia.org/r/444569

gerritbot added a project: Patch-For-Review.Jul 9 2018, 11:59 AM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration1 board.Jul 9 2018, 12:00 PM

Lucas_Werkmeister_WMDE mentioned this in rEWLE559c5d83e5fd: Add SenseSet class.Jul 9 2018, 12:00 PM

Addshore closed this task as Resolved.Jul 10 2018, 10:09 AM

Addshore moved this task from Peer Review to Test (Product Review) on the Wikidata-Senses-Iteration1 board.

Addshore moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration1 board.

Addshore mentioned this in rEWLE490de5a9cbd4: Add SenseSet class.Jul 10 2018, 10:31 AM

Lucas_Werkmeister_WMDE mentioned this in rEWLE90e7c2f6af5c: Add SenseSet class.Jul 10 2018, 10:42 AM

Lucas_Werkmeister_WMDE mentioned this in rEWLEa2758e5aba2b: Add SenseSet class.Jul 10 2018, 12:36 PM

Change 444569 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add SenseSet class

https://gerrit.wikimedia.org/r/444569

Let’s reopen this, I don’t feel like creating a separate task for using the new class :)

Change 444882 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use SenseSet in Lexeme

https://gerrit.wikimedia.org/r/444882

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration1 board.Jul 10 2018, 1:43 PM

Lucas_Werkmeister_WMDE mentioned this in rEWLEcac583a1325f: Use SenseSet in Lexeme.Jul 10 2018, 1:45 PM

Change 444882 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use SenseSet in Lexeme

https://gerrit.wikimedia.org/r/444882

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 10 2018, 5:39 PM

Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Senses-Iteration1 board.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 11 2018, 1:02 AM