Page MenuHomePhabricator
Create Task
Maniphest T206863

Enable mobile-specific html to be rendered within Wikibase
Closed, ResolvedPublic
Actions

Description

We want to be able to render mobile-specific termbox html on the server, so we need to be able to swap out (parts of?) the EntityView depending on the type of device. The mobile-specific termbox html should be rendered by the external node service if the respective config variable is set, otherwise fall back to the standard termbox html.

Techincal notes:

  • the MobileFrontend extension has MobileContext::isMobileDevice
  • at the moment WB renders the same html, mobile or not
  • RepoHooks::onBeforePageDisplayMobile happens after the html is generated

Details

SubjectRepoBranchLines +/-
Render new termbox for mobile devicesmediawiki/extensions/Wikibasemaster+346 -4
LexemeView: return ViewContentmediawiki/extensions/WikibaseLexememaster+33 -19
EntityDocumentView: let view control placeholdersmediawiki/extensions/Wikibasemaster+218 -98
MediaInfoView: adopt wikibase changesmediawiki/extensions/WikibaseMediaInfomaster+19 -13
view-factory-callback: adopt wikibase changesmediawiki/extensions/WikibaseMediaInfomaster+13 -14
EntityViewPlaceholderExpander: method visibilitymediawiki/extensions/Wikibasemaster+9 -9
Reduce Item/Property specific code used in EntityParserOutputGeneratormediawiki/extensions/Wikibasemaster+398 -237
Render different EntityTermsView for mobile devicesmediawiki/extensions/Wikibasemaster+487 -222
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE triaged this task as Medium priority.Oct 12 2018, 3:10 PM
Jakob_WMDE created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2018, 3:10 PM
Jakob_WMDE claimed this task.Oct 16 2018, 9:46 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration1 board.
Addshore moved this task from incoming to in progress on the Wikidata board.Oct 16 2018, 1:49 PM
• Lea_WMDE added a project: Wikidata-Termbox-Iteration-2.Oct 17 2018, 9:10 AM
• Lea_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-2 board.
gerritbot subscribed.Oct 19 2018, 4:09 PM

Change 468329 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Render different EntityTermsView for mobile devices

https://gerrit.wikimedia.org/r/468329

gerritbot added a project: Patch-For-Review.Oct 19 2018, 4:09 PM
gerritbot added a comment.Oct 24 2018, 3:33 PM

Change 469448 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Reduce Item/Property specific code used in EntityParserOutputGenerator

https://gerrit.wikimedia.org/r/469448

gerritbot added a comment.Oct 25 2018, 4:36 PM

Change 469645 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Render new termbox for mobile devices

https://gerrit.wikimedia.org/r/469645

gerritbot added a comment.Oct 26 2018, 4:48 PM

Change 469931 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] EntityViewPlaceholderExpander: method visibility

https://gerrit.wikimedia.org/r/469931

gerritbot added a comment.Oct 26 2018, 5:50 PM

Change 469953 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] EntityDocumentView: let view control placeholders

https://gerrit.wikimedia.org/r/469953

gerritbot added a comment.Oct 30 2018, 2:54 PM

Change 470608 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeView: return PlaceholderEnabledView

https://gerrit.wikimedia.org/r/470608

• Pablo-WMDE mentioned this in rEWLE2386972b8754: LexemeView: return PlaceholderEnabledView.Oct 30 2018, 2:55 PM
• Pablo-WMDE mentioned this in rEWLE5d8a9f856fea: LexemeView: return PlaceholderEnabledView.Oct 30 2018, 3:58 PM
• Lea_WMDE added a project: Wikidata-Termbox-Iteration-3.Oct 31 2018, 9:45 AM
• Lea_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-3 board.
• Pablo-WMDE mentioned this in rEWLEdfe29770f930: LexemeView: return PlaceholderEnabledView.Nov 1 2018, 11:39 AM
• Pablo-WMDE mentioned this in rEWLEadecdf7ba966: LexemeView: return ViewContent.Nov 1 2018, 12:34 PM
gerritbot added a comment.Nov 1 2018, 2:24 PM

Change 471012 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] View: adopt wikibase changes

https://gerrit.wikimedia.org/r/471012

• Pablo-WMDE mentioned this in rEWBI8ec8b481814e: View: adopt wikibase changes.Nov 1 2018, 2:26 PM
• Pablo-WMDE mentioned this in rEWBI27161bc82a29: View: adopt wikibase changes.Nov 1 2018, 2:59 PM
gerritbot added a comment.Nov 5 2018, 10:11 AM

Change 469645 abandoned by Jakob:
Render new termbox for mobile devices

Reason:
Split out into I65e085be0421b58adc615a98bc778ee3e928a1a1 I6d70aaf6fac2389e337592350c6db0faa53340b0 ff.

https://gerrit.wikimedia.org/r/469645

gerritbot added a comment.Nov 5 2018, 10:12 AM

Change 469645 restored by Jakob:
Render new termbox for mobile devices

https://gerrit.wikimedia.org/r/469645

gerritbot added a comment.Nov 5 2018, 10:13 AM

Change 468329 abandoned by Jakob:
Render different EntityTermsView for mobile devices

Reason:
Split out into I65e085be0421b58adc615a98bc778ee3e928a1a1 I6d70aaf6fac2389e337592350c6db0faa53340b0 ff.

https://gerrit.wikimedia.org/r/468329

gerritbot added a comment.Nov 5 2018, 4:49 PM

Change 469448 merged by Addshore:
[mediawiki/extensions/Wikibase@master] Reduce Item/Property specific code used in EntityParserOutputGenerator

https://gerrit.wikimedia.org/r/469448

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 5 2018, 5:01 PM
Addshore mentioned this in rEWBIc00bc6381c10: View: adopt wikibase changes.Nov 5 2018, 10:50 PM
gerritbot added a comment.Nov 6 2018, 12:40 AM

Change 469931 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityViewPlaceholderExpander: method visibility

https://gerrit.wikimedia.org/r/469931

gerritbot added a comment.Nov 6 2018, 10:22 AM

Change 471933 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseMediaInfo@master] MediaInfoView: adopt wikibase changes

https://gerrit.wikimedia.org/r/471933

Jakob_WMDE mentioned this in rEWBI5c74752e4aae: MediaInfoView: adopt wikibase changes.Nov 6 2018, 10:26 AM
Jakob_WMDE mentioned this in rEWBI99ef92ac3a12: view-factory-callback: adopt wikibase changes.
Jakob_WMDE mentioned this in rEWBIb04d0d452647: MediaInfoView: adopt wikibase changes.Nov 6 2018, 10:30 AM
Jakob_WMDE mentioned this in rEWBI7651fa9c6f64: view-factory-callback: adopt wikibase changes.Nov 6 2018, 10:40 AM
Jakob_WMDE mentioned this in rEWLE665dea638009: LexemeView: return ViewContent.Nov 6 2018, 11:06 AM
Jakob_WMDE mentioned this in rEWBI75ecc02eb7b3: MediaInfoView: adopt wikibase changes.Nov 6 2018, 11:19 AM
gerritbot added a comment.Nov 6 2018, 12:45 PM

Change 471012 merged by Addshore:
[mediawiki/extensions/WikibaseMediaInfo@master] view-factory-callback: adopt wikibase changes

https://gerrit.wikimedia.org/r/471012

• Pablo-WMDE mentioned this in rEWBIdb7131e85bba: MediaInfoView: adopt wikibase changes.Nov 6 2018, 4:00 PM
• Pablo-WMDE mentioned this in rEWLE570accfc78b1: LexemeView: return ViewContent.
Jakob_WMDE mentioned this in rEWBIe3d028ef4a87: MediaInfoView: adopt wikibase changes.Nov 6 2018, 4:04 PM
gerritbot added a comment.Nov 6 2018, 4:05 PM

Change 470608 merged by Jakob:
[mediawiki/extensions/WikibaseLexeme@master] LexemeView: return ViewContent

https://gerrit.wikimedia.org/r/470608

gerritbot added a comment.Nov 6 2018, 4:05 PM

Change 469953 merged by Jakob:
[mediawiki/extensions/Wikibase@master] EntityDocumentView: let view control placeholders

https://gerrit.wikimedia.org/r/469953

gerritbot added a comment.Nov 6 2018, 4:05 PM

Change 471933 merged by Jakob:
[mediawiki/extensions/WikibaseMediaInfo@master] MediaInfoView: adopt wikibase changes

https://gerrit.wikimedia.org/r/471933

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.4; 2018-11-13); removed MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 6 2018, 7:02 PM
gerritbot added a comment.Nov 7 2018, 3:12 PM

Change 469645 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Render new termbox for mobile devices

https://gerrit.wikimedia.org/r/469645

WMDE-leszek added a project: Wikidata-Termbox-Iteration-4.Nov 12 2018, 1:09 PM
WMDE-leszek moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-4 board.
Jakob_WMDE closed this task as Resolved.Nov 12 2018, 4:08 PM
Jakob_WMDE moved this task from Doing to Done on the Wikidata-Termbox-Iteration-4 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits