Page MenuHomePhabricator
Create Task
Maniphest T218111

Respect user specified languages in CSR
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

wb getUserLanguages leverages mw.config.get( 'wbUserSpecifiedLanguages' ) and falls back to mw.uls.getFrequentLanguageList() while termbox only makes use of the latter in CSR. In order to provide consistent and correctly user-tailored results in termbox we should change the implementation accordingly.

AC

  • termbox CSR uses mw.config.get( 'wbUserSpecifiedLanguages' ) and falls back to mw.uls.getFrequentLanguageList() to determine user's preferred languages

Info

  • termbox SSR already receives the (correct) result of LanguageFallbackChainFactory::newFromContext( OutputPage ) but CSR overwrites this with incorrectly tailored preferred languages when it comes into effect

Details

SubjectRepoBranchLines +/-
termbox: update pinmediawiki/extensions/Wikibasemaster+1 -1
Switch to wb.getUserLanguages()wikibase/termboxmaster+24 -60
getUserLanguages: allow use in termboxmediawiki/extensions/Wikibasemaster+1 -0
getUserLanguages: polish tests of newly extracted methodmediawiki/extensions/Wikibasemaster+55 -80
Extract getUserLanguages from entityViewInit for reusemediawiki/extensions/Wikibasemaster+148 -23
Customize query in gerrit

Related Objects

Event Timeline

• Pablo-WMDE created this task.Mar 12 2019, 3:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2019, 3:19 PM
• Pablo-WMDE moved this task from Backlog to MVP things: Ready for pickup on the Wikidata-Termbox board.Mar 12 2019, 3:20 PM
• Pablo-WMDE updated the task description. (Show Details)
Jakob_WMDE mentioned this in T214679: Caching Termbox output on the Wikibase side.Mar 12 2019, 4:24 PM
• Pablo-WMDE updated the task description. (Show Details)Mar 13 2019, 9:21 AM
• Pablo-WMDE updated the task description. (Show Details)Mar 13 2019, 9:29 AM
• Lea_WMDE set the point value for this task to 3.Mar 13 2019, 3:54 PM
Jakob_WMDE claimed this task.Mar 13 2019, 5:03 PM
Jakob_WMDE edited projects, added Wikidata-Termbox-Iteration-11; removed Wikidata-Termbox.
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-11 board.Mar 13 2019, 5:10 PM
gerritbot subscribed.Mar 13 2019, 5:56 PM

Change 496218 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Extract getUserLanguages from entityViewInit for reuse

https://gerrit.wikimedia.org/r/496218

gerritbot added a project: Patch-For-Review.Mar 13 2019, 5:56 PM
• Pablo-WMDE added a comment.EditedMar 13 2019, 6:43 PM

@Jakob_WMDE Thanks for picking this up. It appears T213732 first mentions the magic number 4 (now USER_TOP_SECONDARY_LANGUAGES_LIMIT) but does so by incompletely quoting entityViewInit's getUserLanguages(). If we now directly consume getUserLanguages() (which already ensures this limit for uls.getFrequentLanguageList(), and only for this) it looks like we can completely lose our custom limit.
I could not find a product requirement stating "termbox should never show more than 4 languages in the more languages section", rather "the 'more languages' section contains entity information in the languages that are most likely to be spoken by the user, minus the primary language already shown above" (T211865).

• Pablo-WMDE reassigned this task from Jakob_WMDE to • Matthias_Geisler_WMDE.Mar 14 2019, 11:06 AM
gerritbot added a comment.Mar 14 2019, 2:02 PM

Change 496442 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Switch to wb.getUserLanguages()

https://gerrit.wikimedia.org/r/496442

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-11 board.Mar 14 2019, 2:18 PM
gerritbot added a comment.Mar 15 2019, 2:14 PM

Change 496779 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] getUserLanguages: polish tests of newly extracted method

https://gerrit.wikimedia.org/r/496779

gerritbot added a comment.Mar 15 2019, 2:16 PM

Change 496780 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] getUserLanguages: allow use in termbox

https://gerrit.wikimedia.org/r/496780

Jakob_WMDE claimed this task.Mar 19 2019, 10:16 AM
Jakob_WMDE moved this task from Peer Review to Doing on the Wikidata-Termbox-Iteration-11 board.
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-11 board.Mar 19 2019, 11:40 AM
gerritbot added a comment.Mar 19 2019, 1:24 PM

Change 496442 had a related patch set uploaded (by Jakob; owner: Matthias Geisler):
[wikibase/termbox@master] Switch to wb.getUserLanguages()

https://gerrit.wikimedia.org/r/496442

gerritbot added a comment.Mar 20 2019, 12:40 PM

Change 496218 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Extract getUserLanguages from entityViewInit for reuse

https://gerrit.wikimedia.org/r/496218

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 20 2019, 1:01 PM
gerritbot added a comment.Mar 20 2019, 1:09 PM

Change 496779 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] getUserLanguages: polish tests of newly extracted method

https://gerrit.wikimedia.org/r/496779

gerritbot added a comment.Mar 20 2019, 1:09 PM

Change 496780 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] getUserLanguages: allow use in termbox

https://gerrit.wikimedia.org/r/496780

gerritbot added a comment.Mar 20 2019, 2:04 PM

Change 496442 merged by jenkins-bot:
[wikibase/termbox@master] Switch to wb.getUserLanguages()

https://gerrit.wikimedia.org/r/496442

gerritbot added a comment.Mar 20 2019, 2:09 PM

Change 497774 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: update pin

https://gerrit.wikimedia.org/r/497774

Tarrow added a comment.Mar 20 2019, 4:47 PM

This seems to me to be done in wikibase/termbox but we are still waiting on updating the pin. This is blocked by diffusion / gerrit sadness. See: T218780

Tarrow moved this task from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-11 board.Mar 21 2019, 10:42 AM
gerritbot added a comment.Mar 21 2019, 11:12 AM

Change 497774 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: update pin

https://gerrit.wikimedia.org/r/497774

• Lea_WMDE added a comment.Mar 21 2019, 2:20 PM

I'm not sure how I can test the CRS part of it. I did see the beautiful babel box magic in a ticket I was testing earlier this week, but I understand it right that this ticket is specifically about having it rendered in CSR, not SSR? If yet, how can I produce such a situation?

Jakob_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-11 board.Mar 25 2019, 11:44 AM
• Pablo-WMDE closed this task as Resolved.Apr 8 2019, 10:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits