Some edits made by extended confirmed users are no longer automatically accepted
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jontel
	Feb 21 2021, 6:37 PM

Description

I am an extended confirmed user editor on Wikipedia. On Michael Rosen, which is pending changes protected, my 8 Feb edit https://en.wikipedia.org/w/index.php?title=Michael_Rosen&type=revision&diff=1005571365&oldid=1005008162 was automatically accepted, but those of 19 Feb were not e.g. (the first one) https://en.wikipedia.org/w/index.php?title=Michael_Rosen&type=revision&diff=1007735566&oldid=1007730996. The edit history shows the issue more clearly: https://en.wikipedia.org/w/index.php?title=Michael_Rosen&action=history
I have not had this problem before.
The issue is the same for all pending changes protected articles which I have subsequently edited e.g.
https://en.wikipedia.org/w/index.php?title=2008_Mumbai_attacks&action=history
I can continue to edit articles which are not pending change protected as before, included those with extended protection and extended confirmed protection.

STEPS TO REPRODUCE

Find an article with pending changes protection ([[Category:Wikipedia_pending_changes_protected_pages]])
Click on Edit
Change something
Click on Submit changes

ACTUAL RESULTS

The edit appears in the edit history as a pending edit with the notice “pending review”. The edit is not made to the article until it is accepted by a pending changes reviewer.

EXPECTED RESULTS

The edit is automatically accepted.

Additional details

I use Microsoft Windows and Chrome on a desktop. The issue is the same on Firefox.

Details

	Subject	Repo	Branch	Lines +/-
	Run setup from MediaWikiServices hook.	mediawiki/extensions/FlaggedRevs	master	+3 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T234743 User rights validation is sometimes malfunctioning (with FlaggedRevs only?)
		Resolved		Tgr	T275322 Some edits made by extended confirmed users are no longer automatically accepted

Event Timeline

Jontel created this task.Feb 21 2021, 6:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2021, 6:37 PM

Jontel mentioned this in T273317: some users with access are unable to configure pending changes.Feb 21 2021, 6:42 PM

Urbanecm renamed this task from Am an extended confirmed editor on Wikipedia but my edits of articles with pending changes protection are no longer automatically accepted to Some edits made by extended confirmed users at en.wikipedia are no longer automatically accepted.Feb 21 2021, 9:08 PM

Urbanecm added a project: FlaggedRevs.

Urbanecm added a project: Regression.

Urbanecm updated the task description. (Show Details)Feb 21 2021, 9:11 PM

MBH subscribed.Feb 22 2021, 12:19 AM

Change 666587 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FlaggedRevs@master] Run setup from MediaWikiServices hook.

https://gerrit.wikimedia.org/r/666587

gerritbot added a project: Patch-For-Review.Feb 24 2021, 9:53 AM

Reporting an additional incident of this bug. enwiki user DiamondIIIXX came into #wikipedia-en-help tonight and inquired about Pending Changes rights issues. We determined that he was having a similar issue as is described in this bug.

Below are some diffs that were caught by Pending Changes, but should not have been.

https://en.wikipedia.org/w/index.php?title=Steve_Smith_(cricketer)&oldid=1009560175
https://en.wikipedia.org/w/index.php?title=List_of_stadiums_by_capacity&diff=prev&oldid=1009397562

DannyS712 mentioned this in T276172: Edits by extended confirmed users doesn't get approved automatically anymore.Mar 1 2021, 9:17 PM

Seen in fawiki too.

Ladsgroup renamed this task from Some edits made by extended confirmed users at en.wikipedia are no longer automatically accepted to Some edits made by extended confirmed users are no longer automatically accepted.Mar 1 2021, 9:22 PM

RandomCanadian subscribed.Mar 3 2021, 3:56 AM

There is also discussion (with more examples) at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Pending_Changes_again . For the record, in my opinion, this problem warrants prompt action, but since there are other issues (including the code for this being apparently abandoned), that might be more complicated than we think. Cheers,

It also boils down to FlaggedRevs not having a maintainer: T185664: Code stewardship review: FlaggedRevs

Ladsgroup mentioned this in T185664: Code stewardship review: FlaggedRevs.Mar 3 2021, 6:02 PM

In T275322#6877358, @RandomCanadian wrote:

There is also discussion (with more examples) at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Pending_Changes_again . For the record, in my opinion, this problem warrants prompt action, but since there are other issues (including the code for this being apparently abandoned), that might be more complicated than we think. Cheers,

I've left a comment at dewiki, but apparently they are not experiencing this kind of issue... [https://de.wikipedia.org/w/index.php?title=Wikipedia%3ATechnik%2FWerkstatt&type=revision&diff=209523517&oldid=209523120] Odd.

It seems like T233561 may be related/the same issue?

@RandomCanadian: Also happens on dewiki.

Zppix mentioned this in T170726: Template-protected and ECP pages being improperly treated as fully protected.Mar 12 2021, 4:25 AM

In T275322#6903581, @FriedhelmW wrote:

@RandomCanadian: Also happens on dewiki.

Thanks for the information. Likely the same issue; then.

Some users on the enwiki thread suggest it might be better to ditch the current implementation of "pending changes" and restart from scratch, if there's nobody who can fix the current issues.

Since the problem occurs randomly, could this be database replication lag?

I have done some work on this extension (e.g. using new icons for it) but the code is +15K lines of convoluted mess which most of it is not enabled in production at all. I have a rather medium-term vision to hollow out the extension. Started making some patches which also gives me better understanding of its internals. It also reimplemented significant parts of mediawiki core which I'm trying to just reuse core. Let's see how it goes...

Carn subscribed.Mar 15 2021, 2:51 PM

Wugapodes moved this task from Backlog to Under review on the FlaggedRevs board.Mar 16 2021, 9:12 PM

Ladsgroup mentioned this in T279127: Enwiki autoreview for flagged revs not working.Apr 2 2021, 9:47 AM

Ladsgroup merged a task: T279127: Enwiki autoreview for flagged revs not working.Apr 2 2021, 10:17 AM

Ladsgroup added a subscriber: hashar.

DannyS712 triaged this task as High priority.Apr 2 2021, 1:26 PM

NightWolf1223 subscribed.Apr 14 2021, 11:45 PM

Change 666587 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Run setup from MediaWikiServices hook.

https://gerrit.wikimedia.org/r/666587

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2021, 10:10 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 15 2021, 11:00 PM

Ladsgroup mentioned this in T275181: "sight this edit" on edit page missing, are "automatically checked".Apr 22 2021, 6:01 PM

hashar unsubscribed.Apr 28 2021, 9:08 AM

Novem_Linguae subscribed.Apr 29 2021, 3:28 PM

As noted in the parent task (T234743#7063693), this might be fixed now. Your help with re-testing it would be appreciated!

I've notified DiamondIIIXX of the changes, and hopefully we hear back soon whether this fixes the issue for them.

In T275322#7064528, @Phuzion wrote:

I've notified DiamondIIIXX of the changes, and hopefully we hear back soon whether this fixes the issue for them.

According to DiamondIIIXX, this issue is now resolved.

Thanks!

MBH unsubscribed.May 6 2021, 11:48 AM

same bug also happens on ckb wiki

Novem_Linguae unsubscribed.Nov 23 2021, 1:08 PM

Some edits made by extended confirmed users are no longer automatically acceptedClosed, ResolvedPublicActions