🟫️ Don't use serialized entity data in use case responses
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Jakob_WMDE
	May 9 2022, 12:58 PM

Description

We found that serializing the entity in the use case forces us to deal with presentation concerns (serialization format, [] vs {}, ...) in the business layer. We will change the response objects to either contain entities or read models, and serialize later in the life-cycle.

Details

	Subject	Repo	Branch	Lines +/-
	REST: Remove EmptyArrayToObjectConverter	mediawiki/extensions/Wikibase	master	+0 -168
	REST: Add ADR 2 - Don't serialize in use cases	mediawiki/extensions/Wikibase	master	+30 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	WMDE-leszek	T307913 🟫️ Don't use serialized entity data in use case responses
Resolved	WMDE-leszek	T308432 🟫️ Serialize in presentation layer for GetItemStatements
Resolved	WMDE-leszek	T308437 🟫️ Change `GetItem` use case to return an `ItemData` object in the response
Resolved	WMDE-leszek	T308438 🟫️ Don't use serialized entity data in `GetItemStatement` use case response

Event Timeline

Jakob_WMDE created this task.May 9 2022, 12:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2022, 12:58 PM

Change 790379 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add ADR 2 - Don't serialize in use cases

https://gerrit.wikimedia.org/r/790379

gerritbot added a project: Patch-For-Review.May 9 2022, 2:17 PM

Jakob_WMDE set the point value for this task to 5.May 11 2022, 12:19 PM

Jakob_WMDE moved this task from Non Product to Sprint 6 on the Wikibase Product Platform (v1) board.

Jakob_WMDE edited projects, added Wikibase Product Platform (v1) (Sprint 6); removed Wikibase Product Platform (v1).

Change 790379 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add ADR 2 - Don't serialize in use cases

https://gerrit.wikimedia.org/r/790379

Maintenance_bot removed a project: Patch-For-Review.May 12 2022, 11:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 12 2022, 12:00 PM

change GetItem use case to return an ItemData object in the response (@Ollie.Shotton_WMDE creates task)
- create ItemData class
- instantiate ItemData in the use case (to be moved into the retriever as part of T307915)
- create ItemDataSerializer
- serialize in presenter
change GetItemStatements to return a StatementList (@Jakob_WMDE creates task)
- serialize in presenter
change GetItemStatement to return a Statement (@Ollie.Shotton_WMDE creates task)
- serialize in presenter

Jakob_WMDE renamed this task from Don't use serialized entity data in use case responses to 🟫️ Don't use serialized entity data in use case responses.May 16 2022, 12:06 PM

Jakob_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 6) board.May 18 2022, 4:11 PM

Change 793408 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove EmptyArrayToObjectConverter

https://gerrit.wikimedia.org/r/793408

gerritbot added a project: Patch-For-Review.May 19 2022, 8:17 AM

Jakob_WMDE added a project: Story.May 19 2022, 9:14 AM

Change 793408 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove EmptyArrayToObjectConverter

https://gerrit.wikimedia.org/r/793408

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 20 2022, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 20 2022, 1:30 AM