Page MenuHomePhabricator
Create Task
Maniphest T347086

Make It Possible to import function-schemata utils, not just require()
Closed, ResolvedPublic
Actions

Description

Description

We currently have some duplicated code in the JS executor. We could avoid this by exporting function-schemata utils, rather than module.exports-ing (standard JS vs. Node). If this causes problems for other services, we can capture the imported dependencies via rollup.js.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • duplicated function-schemata utils functions are no longer duplicated

Completion checklist

Details

SubjectRepoBranchLines +/-
wikifunctions: Upgrade evaluators from 2024-09-24-221243 to 2024-10-08-175510operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2024-09-24-145528 to 2024-10-08-175830operations/deployment-chartsmaster+1 -1
Update function-schemata sub-module to HEAD (23ce017)mediawiki/extensions/WikiLambdamaster+1 -1
wikifunctions: Upgrade evaluators from 2024-02-26-150300 to 2024-04-03-210033operations/deployment-chartsmaster+2 -2
Update function-schemata sub-module to HEAD (97ea4cd)mediawiki/extensions/WikiLambdamaster+5 -5
wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533operations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade evaluators from 2024-02-12-160222 to 2024-02-26-150300operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade evaluators from 2024-01-18-182630 to 2024-02-12-160222operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2024-01-18-182456 to 2024-02-12-155846operations/deployment-chartsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmassaro created this task.Sep 21 2023, 3:51 PM
Jdforrester-WMF triaged this task as Lowest priority.Sep 28 2023, 4:46 PM
Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.
cmassaro changed the task status from Open to In Progress.Feb 7 2024, 12:55 AM
cmassaro claimed this task.
cmassaro removed cmassaro as the assignee of this task.
cmassaro moved this task from Backlog to In Progress on the Abstract Wikipedia team board.
cmassaro moved this task from In Progress to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF changed the task status from In Progress to Open.Feb 8 2024, 4:00 PM
cmassaro claimed this task.Feb 8 2024, 9:06 PM
CodeReviewBot added a project: Patch-For-Review.Feb 8 2024, 9:56 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/86

Move ZObjectKeyFactory to utils so it can be used by downstream consumers.

CodeReviewBot added a comment.Feb 8 2024, 9:58 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/87

Draft: Apine implement stable stringify

CodeReviewBot added a comment.Feb 9 2024, 1:33 AM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/85

Draft: Allow utils to be imported and required as both ES6 and CommonJS.

cmassaro changed the task status from Open to In Progress.Feb 9 2024, 3:13 PM
cmassaro moved this task from Backlog to In Progress on the Abstract Wikipedia team board.
CodeReviewBot added a comment.Feb 9 2024, 5:28 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/86

Move ZObjectKeyFactory to utils so it can be used by downstream consumers.

gerritbot added a comment.Feb 12 2024, 3:04 PM

Change 1002570 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (786c586)

https://gerrit.wikimedia.org/r/1002570

gerritbot added a comment.Feb 12 2024, 9:02 PM

Change 1002624 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-01-18-182456 to 2024-02-12-155846

https://gerrit.wikimedia.org/r/1002624

gerritbot added a comment.Feb 12 2024, 9:02 PM

Change 1002625 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-01-18-182630 to 2024-02-12-160222

https://gerrit.wikimedia.org/r/1002625

CodeReviewBot added a comment.Feb 12 2024, 9:52 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/85

Allow utils to be imported and required as both ES6 and CommonJS.

CodeReviewBot added a comment.Feb 12 2024, 10:16 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/89

Fix commonJsUtils.js to actually be CJS and ES6

CodeReviewBot added a comment.Feb 14 2024, 6:20 PM

jforrester closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/89

Fix commonJsUtils.js to actually be CJS and ES6

gerritbot added a comment.Feb 22 2024, 7:55 PM

Change 1002624 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-01-18-182456 to 2024-02-12-155846

https://gerrit.wikimedia.org/r/1002624

CodeReviewBot added a comment.Feb 26 2024, 3:02 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/171

Update function-schemata sub-module to HEAD (04c5c89)

gerritbot added a comment.Feb 28 2024, 3:06 PM

Change 1002625 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-01-18-182630 to 2024-02-12-160222

https://gerrit.wikimedia.org/r/1002625

gerritbot added a comment.Feb 28 2024, 3:17 PM

Change 1007353 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-12-160222 to 2024-02-26-150300

https://gerrit.wikimedia.org/r/1007353

gerritbot added a comment.Feb 28 2024, 3:21 PM

Change 1007353 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-12-160222 to 2024-02-26-150300

https://gerrit.wikimedia.org/r/1007353

CodeReviewBot added a comment.Mar 1 2024, 8:10 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/32

Update function-schemata sub-module to HEAD (04c5c89)

CodeReviewBot added a comment.Mar 1 2024, 8:15 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/137

Update function-schemata sub-module to HEAD (04c5c89)

gerritbot added a comment.Mar 5 2024, 2:44 PM

Change 1008874 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533

https://gerrit.wikimedia.org/r/1008874

gerritbot added a comment.Mar 5 2024, 7:59 PM

Change 1008874 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533

https://gerrit.wikimedia.org/r/1008874

gerritbot added a comment.Mar 5 2024, 8:34 PM

Change 1002570 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (97ea4cd)

https://gerrit.wikimedia.org/r/1002570

CodeReviewBot added a comment.Mar 14 2024, 12:14 AM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/187

Move function-schemata to javascript-wasmedge subdir.

CodeReviewBot added a comment.Mar 14 2024, 2:19 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/187

Move function-schemata to javascript-wasmedge subdir.

CodeReviewBot added a comment.Mar 14 2024, 11:40 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/191

Update package-lock with moved function-schemata dependencies.

CodeReviewBot added a comment.Mar 14 2024, 11:53 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/192

Use functions from shared utils rather than re-implementing.

CodeReviewBot added a comment.Mar 15 2024, 3:21 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/191

Update package-lock with moved function-schemata dependencies.

CodeReviewBot added a comment.Mar 18 2024, 8:50 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/103

Remove require() from es6UtilsModule; change file extension to .mjs.

gerritbot added a comment.Apr 4 2024, 1:44 PM

Change #1017061 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-26-150300 to 2024-04-03-210033

https://gerrit.wikimedia.org/r/1017061

gerritbot added a comment.Apr 4 2024, 4:06 PM

Change #1017061 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-26-150300 to 2024-04-03-210033

https://gerrit.wikimedia.org/r/1017061

cmassaro added a subtask: T361132: Orchestrator Should Validate Input Function Call as Z1 (instead of not validating it at all).Apr 9 2024, 7:45 PM
cmassaro added a subtask: T361130: Make Canonicalize and Normalize Equally Strict.
Jdforrester-WMF closed subtask T361132: Orchestrator Should Validate Input Function Call as Z1 (instead of not validating it at all) as Resolved.Apr 29 2024, 6:00 PM
Jdforrester-WMF changed the task status from In Progress to Open.Apr 29 2024, 6:03 PM
Jdforrester-WMF moved this task from In Progress to Backlog on the Abstract Wikipedia team board.
CodeReviewBot added a comment.Sep 25 2024, 9:50 PM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/167

Restrict createZObjectKey and callers to normal form only.

CodeReviewBot added a comment.Sep 26 2024, 2:35 PM

apine closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/103

Draft: Remove require() from es6UtilsModule; change file extension to .mjs.

CodeReviewBot added a comment.Sep 26 2024, 5:17 PM

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/167

Restrict createZObjectKey and callers to normal form only.

CodeReviewBot added a comment.Sep 26 2024, 7:37 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/259

Update function-schemata sub-module to HEAD (23ce017)

gerritbot added a comment.Sep 26 2024, 9:32 PM

Change #1076037 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (23ce017)

https://gerrit.wikimedia.org/r/1076037

CodeReviewBot added a comment.Sep 26 2024, 9:34 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/52

Update function-schemata sub-module to HEAD (23ce017)

CodeReviewBot added a comment.Sep 26 2024, 9:34 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/237

Update function-schemata sub-module to HEAD (23ce017)

CodeReviewBot added a comment.Sep 27 2024, 6:08 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/237

Update function-schemata sub-module to HEAD (23ce017)

CodeReviewBot added a comment.Sep 27 2024, 6:08 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/52

Update function-schemata sub-module to HEAD (23ce017)

CodeReviewBot added a comment.Sep 27 2024, 6:10 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/259

Update function-schemata sub-module to HEAD (23ce017)

gerritbot added a comment.Sep 27 2024, 6:20 PM

Change #1076037 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (23ce017)

https://gerrit.wikimedia.org/r/1076037

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.25; 2024-10-01).Sep 27 2024, 7:00 PM
CodeReviewBot added a comment.Oct 1 2024, 8:05 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/192

Use functions from shared utils rather than re-implementing.

gerritbot added a comment.Oct 9 2024, 2:03 PM

Change #1078949 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-09-24-145528 to 2024-10-08-175830

https://gerrit.wikimedia.org/r/1078949

gerritbot added a comment.Oct 9 2024, 2:03 PM

Change #1078950 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-09-24-221243 to 2024-10-08-175510

https://gerrit.wikimedia.org/r/1078950

gerritbot added a comment.Oct 9 2024, 2:06 PM

Change #1078949 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-09-24-145528 to 2024-10-08-175830

https://gerrit.wikimedia.org/r/1078949

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q2 (Oct–Dec)); removed Abstract Wikipedia team.Oct 9 2024, 2:11 PM
Jdforrester-WMF moved this task from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.
gerritbot added a comment.Oct 9 2024, 2:14 PM

Change #1078950 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-09-24-221243 to 2024-10-08-175510

https://gerrit.wikimedia.org/r/1078950

Jdforrester-WMF closed this task as Resolved.Oct 30 2024, 2:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits