fix: make terminal raw in ssh command on windows #12990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were making it raw, but not raw enough. It needs a few extra modes enabled to function with arrows etc.
kylecarbs
reviewed
Apr 17, 2024
mafredri
approved these changes
Apr 17, 2024
|
Moved the files to pty package and changed it so there's only one set public function for all platforms. Re-tested |
|
Wow sounds nice! Can not await to test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were making it raw, but not raw enough. It needs a few extra modes enabled to function with arrows etc.
Code taken from Coder v1 where we had the same problem.
Tested manually on both Linux and Windows to ensure that left and right arrows work when editing the prompt, htop works (arrow keys, mouse clicks, escape key), resizing works.