feat: create database tables and queries for notifications #13536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @dannykopping and the rest of your teammates on |
1cb776a to
25636ec
Compare
mtojek
reviewed
Jun 12, 2024
johnstcn
reviewed
Jun 12, 2024
coderd/database/migrations/testdata/fixtures/000219_notifications.up.sql
Outdated
Show resolved
Hide resolved
johnstcn
approved these changes
Jun 12, 2024
mtojek
approved these changes
Jun 12, 2024
1c4046c to
538bc42
Compare
spikecurtis
reviewed
Jun 12, 2024
coderd/database/migrations/testdata/fixtures/000219_notifications.up.sql
Outdated
Show resolved
Hide resolved
538bc42 to
438bcba
Compare
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
This has the unfortunate side-effect of not allowing the AcquireNotificationMessagesRow.Payload type to be overriden to []byte as it was previously, but it does not change the semantics Signed-off-by: Danny Kopping <danny@coder.com>
438bcba to
c1a3010
Compare
dannykopping
commented
Jun 27, 2024
There was a problem hiding this comment.
@spikecurtis I'm back from PTO. I believe I've addressed all of your comments.
Can you please have another look?
spikecurtis
approved these changes
Jun 27, 2024
| WHEN (attempt_count + 1 < @max_attempts::int) | ||
| THEN NOW() + CONCAT(@retry_interval::int, ' seconds')::interval END | ||
| FROM (SELECT id, status, status_reason, failed_at | ||
| FROM new_values) AS subquery |
There was a problem hiding this comment.
This query is also doing the WITH new_values thing where we then essentially rename new_values to subquery. Can be simplified to remove the WITH clause and unnest the values here in the FROM clause.
Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates two new tables:
notification_templates: templates are used to create notifications from, and specify a unique event in the systemnotification_messages: each record corresponds to a separate notification which must be delivered to a userAcquireNotificationMessages)coderd/database/migrations/000219_notifications.up.sqlinserts a single template ("Workspace Deleted"), for which we are creating this vertical slice in this initial stack of PRs.