feat(site): support match option for auto create workspace flow #13836
Conversation
| const richParameters: RichParameter[] = [ | ||
| { ...emptyParameter, name: "repo", type: "string" }, | ||
| ]; | ||
| const template = await createTemplate( |
There was a problem hiding this comment.
I haven't worked with the E2E stuff much yet, so just to make sure I'm understanding: these tests aren't isolated, right? That's how the second test is able to have a workspace already exist, even though it didn't explicitly make two of them?
There was a problem hiding this comment.
They are not isolated, but I ensure that a previous workspace with the right match exists in line 39.
| }); | ||
|
|
||
| onCreateWorkspace(newWorkspace); | ||
| } catch (err) { | ||
| searchParams.delete("mode"); | ||
| setSearchParams(searchParams); | ||
| setMode("form"); |
There was a problem hiding this comment.
I'm wondering if it might still be good to update the search params on top of the state change, but good catch with this
There was a problem hiding this comment.
I've thought about this and I don't think it makes much of a difference in the user experience, based on what I can see. Since no other part of the component uses it, I just removed it and decided to set the mode only in the state.
This feature will support having a
matchproperty incoder.yamlfor the Coder Chrome plugin.Related to https://github.com/coder/chrome-coder/issues/1