Skip to content

fix: add version information to default docs links #14205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

bcpeinhardt
Copy link
Contributor

This PR adds version information to the default docs links. If the user set's the docs link themselves it won't mess with it.
It also moves a helper function for getting embedded build info into utils and adds a little cache.

fixes #13369

Copy link

alwaysmeticulous bot commented Aug 7, 2024

🤖 Meticulous replayed 100 user sessions and took 1261 visual snapshots. Meticulous has not yet run on 238e995 of the main branch and so there was nothing to compare against.
If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch.

Last updated for commit 52d60dc. This comment will update as new commits are pushed.

@bcpeinhardt bcpeinhardt requested a review from matifali August 8, 2024 12:47
@matifali matifali requested review from a team and aslilac and removed request for a team August 8, 2024 13:08
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

bcpeinhardt and others added 2 commits August 8, 2024 17:13
Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
@bcpeinhardt bcpeinhardt merged commit d6c4d47 into main Aug 9, 2024
28 of 30 checks passed
@bcpeinhardt bcpeinhardt deleted the bcpeinhardt/add_version_information_to_docs_links branch August 9, 2024 01:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to versioned docs in the product
2 participants