fix: use __SVELTEKIT_PAYLOAD__
to reference boot payload
#14127
Merged
+61
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #14121, which eliminates the (already remote) possibility of race conditions. It does so by making the entire boot payload (the
__sveltekit_abc123 = {...}
object that exists in the hydration<script>
) accessible via a__SVELTEKIT_PAYLOAD__
define.No test because the failure conditions are quite hard to engineer. But this general approach feels more robust than what we have now, and could enable further simplifications (by reducing the need for virtual modules, etc)
Fixes #14120
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits