Skip to content

feat(core): Multiple box-shadows support #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Aug 11, 2025

PR Checklist

What is the current behavior?

Right now, views can only have a single box-shadow.

What is the new behavior?

Views can have multiple box-shadows.

Few improvements to note:

  • Android shadows will respect transparent background without the need of an overlay layer
  • Android shadows will render a solid shadow when blur radius is <= 0
  • Added multipliers to match native shadow blur with CSS shadow blur based on discussion in fix(ios): consistent box-shadow radius blur #10583

Fixes/Implements/Closes #[Issue Number].

BREAKING CHANGES:

Shadow blur changes to match the CSS shadow blur.
The formulas are based on these sources:
https://bjango.com/articles/matchingdropshadows

Apple UX guide also confirms the iOS formula:
https://microsoft.github.io/apple-ux-guide/Shadows.html

Copy link

nx-cloud bot commented Aug 11, 2025

View your CI Pipeline Execution ↗ for commit 1b0cae0

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 5m 40s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-11 15:19:00 UTC

@CatchABus CatchABus marked this pull request as ready for review August 11, 2025 11:35
@CatchABus CatchABus marked this pull request as draft August 11, 2025 14:02
@CatchABus CatchABus marked this pull request as ready for review August 11, 2025 14:07
@CatchABus CatchABus marked this pull request as draft August 11, 2025 15:05
@CatchABus CatchABus marked this pull request as ready for review August 11, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant