Skip to content

chore(clerk-js): Rename task key from select-organization to choose-organization #6482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

chore(clerk-js): Rename task key from select-organization to choose-organization #6482

merged 2 commits into from
Aug 7, 2025

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Aug 6, 2025 •
edited by coderabbitai bot
Loading

Description

Follow-up from FAPI changes in favor of renaming select to choose

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor

    • Updated the task key and related URLs from "select-organization" to "choose-organization" across the application and tests, ensuring consistent session task naming and routing.

  • Tests

    • Adjusted test setups and assertions to use the new "choose-organization" task key and URLs.

@LauraBeatris LauraBeatris self-assigned this Aug 6, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a5d1858

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Aug 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 1:59am

@LauraBeatris LauraBeatris requested review from NicolasLopes7 and a team August 6, 2025 20:02
@LauraBeatris LauraBeatris force-pushed the laura/update-session-task-key branch from 87c33e4 to b5b7fae Compare August 6, 2025 20:03
@LauraBeatris LauraBeatris marked this pull request as ready for review August 6, 2025 20:03
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 6, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

This change updates the session task key name from select-organization to choose-organization across multiple packages and test files. The update is reflected in internal constants, type definitions, test fixtures, route mappings, mock session objects, and test setups, ensuring consistency in how the session task is referenced and routed throughout the codebase. No logic, control flow, or exported/public entity signatures are altered beyond the renaming of the task key and its associated route paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • iagodahlem
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a11d09e and a5d1858.

📒 Files selected for processing (1)
  • integration/tests/session-tasks-eject-flow.test.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • integration/tests/session-tasks-eject-flow.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@LauraBeatris LauraBeatris force-pushed the laura/update-session-task-key branch from b5b7fae to 701d106 Compare August 6, 2025 21:51
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 6, 2025 •
edited
Loading

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6482

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6482

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6482

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6482

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6482

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6482

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6482

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6482

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6482

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6482

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6482

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6482

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6482

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6482

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6482

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6482

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6482

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6482

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6482

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6482

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6482

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6482

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6482

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6482

commit: a5d1858

@LauraBeatris LauraBeatris force-pushed the laura/update-session-task-key branch from 701d106 to 782d352 Compare August 6, 2025 22:22
@LauraBeatris LauraBeatris force-pushed the laura/update-session-task-key branch from 782d352 to fde12b9 Compare August 6, 2025 22:28
@LauraBeatris LauraBeatris force-pushed the laura/update-session-task-key branch from fde12b9 to 0031d86 Compare August 6, 2025 22:48
@LauraBeatris LauraBeatris force-pushed the laura/update-session-task-key branch from 0031d86 to 4355745 Compare August 6, 2025 23:07
@LauraBeatris LauraBeatris force-pushed the laura/update-session-task-key branch from 4355745 to c5b2949 Compare August 6, 2025 23:22
@LauraBeatris LauraBeatris force-pushed the laura/update-session-task-key branch from c5b2949 to 36efce9 Compare August 7, 2025 00:05
@LauraBeatris LauraBeatris enabled auto-merge (squash) August 7, 2025 01:31
@LauraBeatris LauraBeatris force-pushed the laura/update-session-task-key branch from 36efce9 to a11d09e Compare August 7, 2025 01:39
@LauraBeatris LauraBeatris merged commit 696f8e1 into main Aug 7, 2025
36 checks passed
@LauraBeatris LauraBeatris deleted the laura/update-session-task-key branch August 7, 2025 02:05
@clerk-cookie clerk-cookie mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasLopes7 NicolasLopes7 NicolasLopes7 approved these changes

Assignees

@LauraBeatris LauraBeatris

Labels
clerk-js integration types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LauraBeatris @NicolasLopes7 @clerk-cookie