Fixed #35673 -- Enhanced ExceptionReporter to handle GET and FILES parameters
#19702
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
reviewed
Aug 6, 2025
tests/view_tests/tests/test_debug.py
Outdated
| @@ -486,6 +486,14 @@ def test_template_override_exception_reporter(self): | |||
| response = self.client.get("/raises500/", headers={"accept": "text/plain"}) | |||
| self.assertContains(response, "Oh dear, an error occurred!", status_code=500) | |||
|
|
|||
| @override_settings(DATA_UPLOAD_MAX_NUMBER_FIELDS=1) | |||
| def test_max_number_of_fields_exceeded(self): | |||
| response = self.client.get("/raises500/", {"a": "1", "b": "2"}) | |||
There was a problem hiding this comment.
Suggested change
| response = self.client.get("/raises500/", {"a": "1", "b": "2"}) | |
| with self.assertLogs("django.request", "ERROR"): | |
| response = self.client.get("/raises500/", {"a": "1", "b": "2"}) |
We want to capture the logging so we don't get noise when running the test
django/views/debug.py
Outdated
| @@ -389,7 +411,7 @@ def get_traceback_data(self): | |||
| "is_email": self.is_email, | |||
| "unicode_hint": unicode_hint, | |||
| "frames": frames, | |||
| "request": self.request, | |||
| "request": SafeExceptionRequest(self.request) if self.request else None, | |||
There was a problem hiding this comment.
Suggested change
| "request": SafeExceptionRequest(self.request) if self.request else None, | |
| "request": self.request, |
We can revert this and remove the SafeExceptionRequest and instead do:
--- a/django/views/templates/technical_500.html
+++ b/django/views/templates/technical_500.html
@@ -354,7 +354,7 @@ Exception Value: {{ exception_value|force_escape }}{% if exception_notes %}{{ ex
{% endif %}
<h3 id="get-info">GET</h3>
- {% if request.GET %}
+ {% if request_GET_items %}
<table class="req">
<thead>
<tr>
@@ -398,7 +398,7 @@ Exception Value: {{ exception_value|force_escape }}{% if exception_notes %}{{ ex
{% endif %}
<h3 id="files-info">FILES</h3>
- {% if request.FILES %}
+ {% if request_FILES_items %}
<table class="req">
<thead>
<tr>There was a problem hiding this comment.
I also think in the template we should consider rendering the error differently rather than have it within a table with "Variable", "Value" headers, something like:
<h3 id="files-info">FILES</h3>
- {% if request.FILES %}
+ {% if request_FILES_items %}
<table class="req">
<thead>
<tr>
@@ -415,6 +415,8 @@ Exception Value: {{ exception_value|force_escape }}{% if exception_notes %}{{ ex
<h3 id="files-info">FILES</h3>
- {% if request.FILES %}
+ {% if request_FILES_items %}
<table class="req">
<thead>
<tr>
@@ -415,6 +415,8 @@ Exception Value: {{ exception_value|force_escape }}{% if exception_notes %}{{ ex
{% endfor %}
</tbody>
</table>
+ {% elif request_FILES_error %}
+ <p>{{ request_FILES_error }}</p>
{% else %}
<p>No FILES data</p>
{% endif %}Where request_FILES_error is the error if available and "" or None otherwise
django/views/debug.py
Outdated
Comment on lines
442
to
451
| try: | ||
| c["request_FILES_items"] = self.request.FILES.items() | ||
| except TooManyFilesSent: | ||
| c["request_FILES_items"] = [ | ||
| ( | ||
| "<could not parse>", | ||
| "Number of FILES parameters exceeded " | ||
| "DATA_UPLOAD_MAX_NUMBER_FILES", | ||
| ) | ||
| ] |
There was a problem hiding this comment.
Suggested change
| try: | |
| c["request_FILES_items"] = self.request.FILES.items() | |
| except TooManyFilesSent: | |
| c["request_FILES_items"] = [ | |
| ( | |
| "<could not parse>", | |
| "Number of FILES parameters exceeded " | |
| "DATA_UPLOAD_MAX_NUMBER_FILES", | |
| ) | |
| ] | |
| c["request_FILES_items"] = self.request.FILES.items() |
Note that this can be reverted without any test failures
We might also want to test for (and possibly handle) too many POST parameters
django/views/debug.py
Outdated
Comment on lines
438
to
439
| "Number of GET paramters exceeded " | ||
| "DATA_UPLOAD_MAX_NUMBER_FIELDS.", |
There was a problem hiding this comment.
I think instead of us defining new text, we can use the text from the error itself (note there is a typo here)
tests/view_tests/views.py
Outdated
| @@ -45,7 +46,7 @@ def raises500(request): | |||
| # We need to inspect the HTML generated by the fancy 500 debug view but | |||
| # the test client ignores it, so we send it explicitly. | |||
| try: | |||
| raise Exception | |||
| raise Exception("Test exception to trigger debug view") | |||
There was a problem hiding this comment.
Suggested change
| raise Exception("Test exception to trigger debug view") | |
| raise Exception |
This change is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35673
Branch description
Problem:
Django's ExceptionReporter crashes with infinite loops when handling requests that exceed
DATA_UPLOAD_MAX_NUMBER_FIELDSlimits, resulting in blank 500 error pages instead of useful debug information.Solution:
Implemented
SafeExceptionRequestwrapper class that safely handlesrequest.GETandrequest.FILESaccess by catchingTooManyFieldsSent/TooManyFilesSentexceptions and returning empty collections with error indicators.Checklist
mainbranch.