Fixed #35673 -- Enhanced ExceptionReporter to handle GET and FILES parameters
#19702
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
reviewed
Aug 6, 2025
django/views/debug.py
Outdated
Comment on lines
442
to
451
| try: | ||
| c["request_FILES_items"] = self.request.FILES.items() | ||
| except TooManyFilesSent: | ||
| c["request_FILES_items"] = [ | ||
| ( | ||
| "<could not parse>", | ||
| "Number of FILES parameters exceeded " | ||
| "DATA_UPLOAD_MAX_NUMBER_FILES", | ||
| ) | ||
| ] |
There was a problem hiding this comment.
Suggested change
| try: | |
| c["request_FILES_items"] = self.request.FILES.items() | |
| except TooManyFilesSent: | |
| c["request_FILES_items"] = [ | |
| ( | |
| "<could not parse>", | |
| "Number of FILES parameters exceeded " | |
| "DATA_UPLOAD_MAX_NUMBER_FILES", | |
| ) | |
| ] | |
| c["request_FILES_items"] = self.request.FILES.items() |
Note that this can be reverted without any test failures
We might also want to test for (and possibly handle) too many POST parameters
sarahboyce
reviewed
Aug 11, 2025
| c["request_FILES_items"] = self.request.FILES.items() | ||
| try: | ||
| c["request_GET_items"] = self.request.GET.items() | ||
| c["request_GET_error"] = None |
There was a problem hiding this comment.
Suggested change
| c["request_GET_error"] = None |
We can omit this
Comment on lines
+489
to
+496
| @override_settings(DATA_UPLOAD_MAX_NUMBER_FIELDS=1) | ||
| def test_max_number_of_fields_exceeded(self): | ||
| with self.assertLogs("django.request", "ERROR"): | ||
| response = self.client.get("/raises500/", {"a": "1", "b": "2"}) | ||
|
|
||
| self.assertEqual(response.status_code, 500) | ||
| self.assertContains(response, '<div class="context" id="', status_code=500) | ||
| self.assertContains(response, "Exception", status_code=500) |
There was a problem hiding this comment.
Suggested change
| @override_settings(DATA_UPLOAD_MAX_NUMBER_FIELDS=1) | |
| def test_max_number_of_fields_exceeded(self): | |
| with self.assertLogs("django.request", "ERROR"): | |
| response = self.client.get("/raises500/", {"a": "1", "b": "2"}) | |
| self.assertEqual(response.status_code, 500) | |
| self.assertContains(response, '<div class="context" id="', status_code=500) | |
| self.assertContains(response, "Exception", status_code=500) | |
| @override_settings(DATA_UPLOAD_MAX_NUMBER_FIELDS=1) | |
| def test_max_number_of_fields_exceeded_get(self): | |
| with self.assertLogs("django.request", "ERROR"): | |
| response = self.client.get("/raises500/", {"a": "1", "b": "2"}) | |
| self.assertEqual(response.status_code, 500) | |
| self.assertContains( | |
| response, | |
| "The number of GET/POST parameters exceeded " | |
| "settings.DATA_UPLOAD_MAX_NUMBER_FIELDS.", | |
| status_code=500 | |
| ) | |
| @override_settings(DATA_UPLOAD_MAX_NUMBER_FILES=1) | |
| def test_max_number_of_fields_exceeded_files(self): | |
| data = { | |
| "file_data.txt": SimpleUploadedFile("file_data.txt", b"data"), | |
| "file_data_2.txt": SimpleUploadedFile("file_data_2.txt", b"data2"), | |
| } | |
| with self.assertLogs("django.request", "ERROR"): | |
| response = self.client.post("/raises/", data) | |
| self.assertContains( | |
| response, | |
| "The number of files exceeded " | |
| "settings.DATA_UPLOAD_MAX_NUMBER_FILES.", | |
| status_code=500 | |
| ) |
You're missing a test for the files case
I have written an example test here but this currently fails because there is not error handling in accessing POST data:
File "/path-to-django/django/views/debug.py", line 398, in get_traceback_data
self.filter.get_post_parameters(self.request).items()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/path-to-django/django/views/debug.py", line 225, in get_post_parameters
return request.POST
^^^^^^^^^^^^
This needs similar error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35673
Branch description
Problem:
Django's ExceptionReporter crashes with infinite loops when handling requests that exceed
DATA_UPLOAD_MAX_NUMBER_FIELDSlimits, resulting in blank 500 error pages instead of useful debug information.Solution:
Implemented
SafeExceptionRequestwrapper class that safely handlesrequest.GETandrequest.FILESaccess by catchingTooManyFieldsSent/TooManyFilesSentexceptions and returning empty collections with error indicators.Checklist
mainbranch.