Skip to content

ref(grouping): Simplify recursive frame handling #97539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lobsterkatie
Copy link
Member

In our grouping algorithm, we ignore recursion, that is to say, we count n consecutive copies of a frame the same as if there were just 1 copy. Currently, in order to do this, we have the stacktrace strategy compare successive frames, and if recursion is detected, we add a flag to the grouping context so that all frames but the first in a recursion mark themselves as non-contributing. This works, but is more complicated than it needs to be.

To simplify things, this PR lets the stacktrace component mark recursive frames non-contributing rather than having the frames do it themselves. This saves us from having to transmit that data through to the frame strategy, and therefore means we don't need to include the data in the grouping context.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 8, 2025
@lobsterkatie lobsterkatie marked this pull request as ready for review August 8, 2025 23:45
@lobsterkatie lobsterkatie requested a review from a team as a code owner August 8, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants