ref(grouping): Simplify recursive frame handling #97539
Open
+3
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our grouping algorithm, we ignore recursion, that is to say, we count n consecutive copies of a frame the same as if there were just 1 copy. Currently, in order to do this, we have the stacktrace strategy compare successive frames, and if recursion is detected, we add a flag to the grouping context so that all frames but the first in a recursion mark themselves as non-contributing. This works, but is more complicated than it needs to be.
To simplify things, this PR lets the stacktrace component mark recursive frames non-contributing rather than having the frames do it themselves. This saves us from having to transmit that data through to the frame strategy, and therefore means we don't need to include the data in the grouping context.