fix(export): show 'Data export requires Business Plan' on 404 for SaaS #97546
Conversation
…; add test; keep generic/self-hosted fallback
static/app/components/dataExport.tsx
Outdated
| t( | ||
| "We tried our hardest, but we couldn't export your data. Give it another go." | ||
| ); | ||
| err?.status === 404 && !isSelfHosted |
There was a problem hiding this comment.
404 seems like the wrong status to return if they dont have the feature - is it worth following this pr up with an update in the backend?
static/app/components/dataExport.tsx
Outdated
| "We tried our hardest, but we couldn't export your data. Give it another go." | ||
| ); | ||
| err?.status === 404 && !isSelfHosted | ||
| ? t('Data export requires Business Plan') |
There was a problem hiding this comment.
shouldn't the button be disabled or removed if they can't export on their plan
There was a problem hiding this comment.
yeah that is probably the better fix
There was a problem hiding this comment.
There was a problem hiding this comment.
i just updated the branch. let me know if that makes sense.
…scover-query; show GS hovercard via hookName
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97546 +/- ##
=======================================
Coverage 80.61% 80.61%
=======================================
Files 8559 8559
Lines 376754 376746 -8
Branches 24492 24491 -1
=======================================
- Hits 303732 303731 -1
+ Misses 72652 72645 -7
Partials 370 370 |
…o hovercard); keep button enabled when feature present
There was a problem hiding this comment.
i think the only change we need to make here is actually disabling/hiding TagExportDropdown if they don't have the feature flag. the button in discover is probably gated, but it's not in the tag drawer on issue details. with that, we shouldn't even need to update the error message since they won't be able to attempt to export
…add spec. dataExport: remove 404 Business Plan messaging and test; rely on gating
| `/${organization.slug}/${project.slug}/issues/${group.id}/tags/${tagKey}/export/`, | ||
| '_blank' | ||
| ); | ||
| <Feature features="organizations:discover-query" organization={organization}> |
There was a problem hiding this comment.
Feature is already wrapped with withOrganization so we shouldn't have to pass organization in here
Right now it is confusing that a user can try and export tags but we do not tell them why. if we're on SaaS, send a more helpful error message.
Ideally, we should probably just gray out the button entirely if the user is not on business with a tooltip.