-
Notifications
You must be signed in to change notification settings - Fork 482
add wan2.2 library #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wan2.2 library #1668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please also wait for other reviewers
Hi @kelseyee , thanks for the PR! Is "Wan2.2" really a new library or just an extension of a broader "Wan" library? (genuinely asking). I have checked https://huggingface.co/models?other=wan2.2 and it doesn't seem to me that there is a common pattern to store files in these repos. I would prefer to see a bit more consistency on how the library deals with files before adding the download counter rule. |
"Wan2.2" is actually a new, standalone library, and the download counter rule is only being enabled specifically for Wan2.2. This is because Wan2.2 is a special MoE model — future versions of the Wan model may not be MoE-based, so we're treating it separately. Also, I was wondering, since the config.json is the default query file, why doesn't it work when it's placed in a subfolder? Is there something in the current logic that expects it to be at the root level? Just trying to better understand how it works. |
Yes the default counting rule counts only the config.json file at root. So doing what you just did is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except a last comment on the download count rule, it looks good to me for a merge.
Could you also open PRs to add library_name: wan2.2
in the model card metadata of Wan2.2 repos? So at least:
- https://huggingface.co/Wan-AI/Wan2.2-TI2V-5B
- https://huggingface.co/Wan-AI/Wan2.2-T2V-A14B
- https://huggingface.co/Wan-AI/Wan2.2-I2V-A14B
Once that's done, we should be able to release it.
Co-authored-by: Lucain <lucainp@gmail.com>
I've added |
Great! I'm merging it now. Should be online in a few days.
I still think it'd be good to tag it as If the 5B repo is not to be run with Wan2.2 library, I think the naming of the repo should be updated (it's confusing otherwise). This doesn't block merging this PR but would still be good to address it while you are at it. |
Good point! I’ve gone ahead and added library_name: wan2.2 to the 5B repo too. Better for visibility and keeps everything aligned. Appreciate the feedback! |
Add wan2.2 library support to count downloads correctly