Skip to content

add wan2.2 library #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 7, 2025
Merged

add wan2.2 library #1668

merged 7 commits into from
Aug 7, 2025

Conversation

kelseyee
Copy link
Contributor

@kelseyee kelseyee commented Aug 4, 2025

Add wan2.2 library support to count downloads correctly

Copy link
Contributor

@xianbaoqian xianbaoqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please also wait for other reviewers

@Wauplin
Copy link
Contributor

Wauplin commented Aug 6, 2025

Hi @kelseyee , thanks for the PR! Is "Wan2.2" really a new library or just an extension of a broader "Wan" library? (genuinely asking).

I have checked https://huggingface.co/models?other=wan2.2 and it doesn't seem to me that there is a common pattern to store files in these repos. I would prefer to see a bit more consistency on how the library deals with files before adding the download counter rule.

@kelseyee
Copy link
Contributor Author

kelseyee commented Aug 7, 2025

Hi @kelseyee , thanks for the PR! Is "Wan2.2" really a new library or just an extension of a broader "Wan" library? (genuinely asking).

I have checked https://huggingface.co/models?other=wan2.2 and it doesn't seem to me that there is a common pattern to store files in these repos. I would prefer to see a bit more consistency on how the library deals with files before adding the download counter rule.

"Wan2.2" is actually a new, standalone library, and the download counter rule is only being enabled specifically for Wan2.2. This is because Wan2.2 is a special MoE model — future versions of the Wan model may not be MoE-based, so we're treating it separately.

Also, I was wondering, since the config.json is the default query file, why doesn't it work when it's placed in a subfolder? Is there something in the current logic that expects it to be at the root level? Just trying to better understand how it works.

@Wauplin
Copy link
Contributor

Wauplin commented Aug 7, 2025

Is there something in the current logic that expects it to be at the root level?

Yes the default counting rule counts only the config.json file at root. So doing what you just did is correct.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except a last comment on the download count rule, it looks good to me for a merge.

Could you also open PRs to add library_name: wan2.2 in the model card metadata of Wan2.2 repos? So at least:

Once that's done, we should be able to release it.

Co-authored-by: Lucain <lucainp@gmail.com>
@kelseyee
Copy link
Contributor Author

kelseyee commented Aug 7, 2025

I've added library_name: wan2.2 to the two 14B repos. The 5B repo doesn't need it since it's not an MoE model, and its download count is already correct. Thanks a lot!

@Wauplin
Copy link
Contributor

Wauplin commented Aug 7, 2025

Great! I'm merging it now. Should be online in a few days.

The 5B repo doesn't need it since it's not an MoE model, and its download count is already correct.

I still think it'd be good to tag it as wan2.2 since this is its main library to use it, right? The download count would still work the same. Tagging it is better for discoverability and to get a direct link to the Wan2.2 repo from this model page.

If the 5B repo is not to be run with Wan2.2 library, I think the naming of the repo should be updated (it's confusing otherwise).

This doesn't block merging this PR but would still be good to address it while you are at it.

@kelseyee
Copy link
Contributor Author

kelseyee commented Aug 7, 2025

I still think it'd be good to tag it as wan2.2 since this is its main library to use it, right? The download count would still work the same. Tagging it is better for discoverability and to get a direct link to the Wan2.2 repo from this model page.

Good point! I’ve gone ahead and added library_name: wan2.2 to the 5B repo too. Better for visibility and keeps everything aligned. Appreciate the feedback!

@Wauplin Wauplin merged commit 96f1bc5 into huggingface:main Aug 7, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants