Skip to content

feat(linter): add vue/valid-define-emits #12545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 08-02-refactor_linter_run_linter_with_contextsubhost_
Choose a base branch
from
Open

feat(linter): add vue/valid-define-emits #12545

wants to merge 1 commit into from

Conversation

Sysix
Copy link
Member

@Sysix Sysix commented Jul 27, 2025 •
edited
Loading

related #11440

https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/valid-define-emits.md

Extended the docs and tests to cover (non) empty defineEmits() with export default of other script block.
Related vuejs/eslint-plugin-vue#2914

This was referenced Jul 27, 2025
Closed
Merged
Merged
@Sysix Graphite App
Copy link
Member Author

Sysix commented Jul 27, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jul 27, 2025
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from e06586b to cf7505c Compare July 27, 2025 12:05
@Sysix Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 4658fba to 8f63297 Compare July 27, 2025 12:05
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 27, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12545 will not alter performance

Comparing 07-27-feat_linter_add_vue_valid-define-emits_ (31250fd) with 08-02-refactor_linter_run_linter_with_contextsubhost_ (2724683)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch 2 times, most recently from 6df5bd5 to 363330d Compare July 27, 2025 12:38
@graphite-app graphite-app bot force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from cf7505c to 3092f5a Compare July 27, 2025 12:38
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 3092f5a to 3a47b3c Compare July 27, 2025 14:55
@Sysix Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 363330d to cb96836 Compare July 28, 2025 18:34
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 93a08b0 to 1e94d0b Compare July 28, 2025 18:34
@Sysix Sysix marked this pull request as ready for review July 28, 2025 18:53
@Sysix Sysix requested a review from camc314 as a code owner July 28, 2025 18:53
graphite-app[bot]
graphite-app bot reviewed Jul 28, 2025
View reviewed changes
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 1e94d0b to 7216d4d Compare July 28, 2025 18:57
@Sysix Sysix marked this pull request as draft July 29, 2025 17:26
This was referenced Jul 29, 2025
Merged
Merged
@Sysix Sysix marked this pull request as ready for review July 29, 2025 20:34
@Sysix Sysix mentioned this pull request Jul 29, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Jul 31, 2025
@Sysix
test(linter): fix offset for partical source texts (#12594)
2ceb835 
Moved this PR into an own stack to fix the bug in #12545
@Sysix Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from cb96836 to cdf6b57 Compare July 31, 2025 17:25
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 7216d4d to 5ee13db Compare July 31, 2025 17:25
@Sysix Sysix marked this pull request as draft August 1, 2025 13:48
@Sysix Sysix changed the base branch from 07-26-refactor_linter_add_setup_detection_for_vue_files to graphite-base/12545 August 3, 2025 12:38
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 5ee13db to e0ff496 Compare August 3, 2025 12:38
@Sysix Sysix force-pushed the graphite-base/12545 branch from cdf6b57 to 9a5d730 Compare August 3, 2025 12:38
@Sysix Sysix changed the base branch from graphite-base/12545 to 08-02-refactor_linter_run_linter_with_contextsubhost_ August 3, 2025 12:38
This was referenced Aug 3, 2025
Open
Open
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch 3 times, most recently from 7fc7ce2 to 9d7836f Compare August 3, 2025 15:22
@Sysix Sysix mentioned this pull request Aug 3, 2025
Closed
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 9d7836f to a59c687 Compare August 4, 2025 17:45
@Sysix Sysix marked this pull request as ready for review August 4, 2025 17:50
graphite-app[bot]
graphite-app bot reviewed Aug 4, 2025
View reviewed changes
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from a59c687 to 6d1cad5 Compare August 4, 2025 17:53
@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 9a5d730 to 4fed1ef Compare August 4, 2025 18:01
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch 3 times, most recently from 42bf821 to f5c9c83 Compare August 5, 2025 17:59
@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 4fed1ef to 0b97694 Compare August 5, 2025 17:59
@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 0b97694 to 2724683 Compare August 9, 2025 14:56
@Sysix Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from f5c9c83 to 31250fd Compare August 9, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees
No one assigned
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sysix