refactor(linter): introduce ContextSubHost for cross script block analyse
#12724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12724 will not alter performanceComparing Summary
|
bf94758 to
23e3b37
Compare
23e3b37 to
646cd76
Compare
f72c007 to
5f79f25
Compare
5f79f25 to
81fac36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another approach to #12541 stack.
Because
vue/valid-define-emitand other rules required the semantics of the other script block.The Goal:
Linter.runshould run with the complete file context. Invuefiles and others, there can be multiple Semantics / Module Records.Because
vuerequires some magic compiler rules, the linter should have access to the complete file.This will also fix the offset bug in #12758.
Don't merge both stacks without rebasing.I do not like the loop part. Maybe you guys have some better ideas.