Skip to content

Tidy torch/csrc/jit/passes/onnx code #160262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Tidy torch/csrc/jit/passes/onnx code #160262

wants to merge 3 commits into from
+27 −26

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Aug 10, 2025 •
edited
Loading

Apply clang-tidy fixes to torch/csrc/jit/passes/onnx

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel

@cyyever cyyever requested a review from titaiwangms as a code owner August 10, 2025 02:34
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160262

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bac0f18 with merge base df55ec7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 10, 2025
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 10, 2025
@cyyever cyyever requested a review from justinchuby August 10, 2025 02:34
@cyyever
Copy link
Collaborator Author

cyyever commented Aug 10, 2025

@justinchuby @titaiwangms We should tidy the code before trying to fix ONNX 1.19 integration.

@cyyever cyyever force-pushed the onnx_tidy branch 3 times, most recently from 44ca5d3 to be40649 Compare August 10, 2025 03:44
@cyyever
Tidy ONNX code
c410fe6 
Signed-off-by: cyy <cyyever@outlook.com>
cyyever added 2 commits August 10, 2025 12:32
@cyyever
Comment out unused functions
e0d3f28
@cyyever
Format code
bac0f18 
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever cyyever changed the title Tidy ONNX code Tidy torch/csrc/jit/passes/onnx code Aug 10, 2025
justinchuby
justinchuby reviewed Aug 10, 2025
View reviewed changes
torch/csrc/jit/passes/onnx/unpack_quantized_weights.cpp
@@ -21,13 +21,14 @@ using namespace ::c10::onnx;

}

#if 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you comment on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby left review comments

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

Assignees
No one assigned
Labels
oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: onnx torch.onnx related changes that should show up in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyyever @justinchuby @facebook-github-bot @pytorchbot