Skip to content

Tidy torch/csrc/jit/passes/onnx code #160262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Tidy torch/csrc/jit/passes/onnx code #160262

wants to merge 5 commits into from
+23 −100

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Aug 10, 2025 •
edited
Loading

Apply clang-tidy fixes to torch/csrc/jit/passes/onnx

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel

@cyyever cyyever requested a review from titaiwangms as a code owner August 10, 2025 02:34
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160262

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 52 Pending

As of commit eac0efa with merge base 05c19d1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 10, 2025
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 10, 2025
@cyyever cyyever requested a review from justinchuby August 10, 2025 02:34
@cyyever
Copy link
Collaborator Author

cyyever commented Aug 10, 2025

@justinchuby @titaiwangms We should tidy the code before trying to fix ONNX 1.19 integration.

@cyyever cyyever force-pushed the onnx_tidy branch 4 times, most recently from be40649 to c410fe6 Compare August 10, 2025 03:51
@cyyever cyyever changed the title Tidy ONNX code Tidy torch/csrc/jit/passes/onnx code Aug 10, 2025
justinchuby
justinchuby reviewed Aug 10, 2025
View reviewed changes
torch/csrc/jit/passes/onnx/unpack_quantized_weights.cpp Outdated
@@ -21,13 +21,14 @@ using namespace ::c10::onnx;

}

#if 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you comment on this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is not used.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment is added.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove then?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If unused we should be able to remove

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is removed.

@cyyever cyyever requested a review from justinchuby August 11, 2025 00:49
justinchuby
justinchuby approved these changes Aug 11, 2025
View reviewed changes
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cyyever added 4 commits August 11, 2025 09:00
@cyyever
Tidy ONNX code
33da693 
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever
Comment out unused functions
9271f60
@cyyever
Format code
d740146 
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever
Remove unused function
4c264a0 
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever
Copy link
Collaborator Author

cyyever commented Aug 11, 2025

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 11, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request merging oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: onnx torch.onnx related changes that should show up in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyyever @pytorchmergebot @justinchuby @facebook-github-bot @pytorchbot