-
Notifications
You must be signed in to change notification settings - Fork 143
Update the auto YAML Generation #7725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
unsur eif schema./yaml is maintained or auto generated.
@mindspank thoughts on this PR?
If approved, ill go back in and overwrite /reference/project-files/ and fix any broken links |
@royendo , we prefer using a single file instead of using imports — like in this example, where everything is in one file. Initially, I had created separate files and imported them into project.schema.yaml, like you did, but @begelundmuller suggested keeping everything in one file. |
@@ -0,0 +1,52 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should call it sql-models.md and rename advanced-models.md to just models.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works, with me but will need to fix quite a bit of links and redirects. should be easy
@@ -49,73 +68,53 @@ _[string]_ - Configure how changes to the model specifications are applied (opti | |||
|
|||
_[oneOf]_ - Refers to the explicitly defined state of your model, cannot be used with partitions (optional) | |||
|
|||
- **option 1** - _[object]_ - Executes a raw SQL query against the project's data models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we remove the options? I think it was clearer before, as it showed that the user could choose any option like sql, metric_sql, api, etc.
|
||
#### `aws_access_key_id` | ||
|
||
_[string]_ - AWS Access Key ID used for authentication. Required when using static credentials directly or as base credentials for assuming a role. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all schemas into one including rillyaml. commented out lines. reworked generate-project.go: - moved out logic for sample in copy, uses schema sample instead - adding in line examples
next will be adding more examples
Separated the schema files for easier management
referenced in project.schema.yaml.
reworked connections to look similar to currrent with copiable form.
models.schema.yaml --> advanced-model.schema.yaml
once confirmed, we can move this to rewrite /reference/project--files/
Checklist: