Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

Update fuzzers for 1.70 and integrate with CI #4570

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update fuzzers for 1.70 and integrate with CI #4570

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ea7125
use oncelock/threadlocal where possible
addisoncrump Jun 14, 2023
b3b688d
fuzz in CI
addisoncrump Jun 28, 2023
7b5bd6c
rename task for clarity
addisoncrump Jun 28, 2023
f4dfc87
fixup: updates affected fuzzers missed
addisoncrump Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fuzz in CI
  • Loading branch information
@addisoncrump
addisoncrump committed Jun 28, 2023
commit b3b688daa2d8561cd1312b9ef34e8838f9bdc81a
4 changes: 4 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ jobs:
bins: cargo-fuzz
- name: Run init-fuzzer
run: bash fuzz/init-fuzzer.sh
- name: Run JS fuzzer for 5 minutes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be reasonable to put these in a github action matrix to run them in parallel jobs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially so, but we would need to transfer the build artifacts from the common init step. OR split the init step. Both are possible.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ig a similar thing to do would be to not fail the job if the first fuzz test run fails so the second can also run, with https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

run: timeout 5m cargo fuzz run --strip-dead-code --features rome_all -s none rome_format_all -- -timeout=5 || [[ $? -eq 124 ]]
- name: Run JSON fuzzer for 5 minutes
run: timeout 5m cargo fuzz run --strip-dead-code -s none rome_format_json -- -timeout=5 || [[ $? -eq 124 ]]

test-node-api:
name: Test node.js API
Expand Down