Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

Update fuzzers for 1.70 and integrate with CI #4570

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update fuzzers for 1.70 and integrate with CI #4570

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ea7125
use oncelock/threadlocal where possible
addisoncrump Jun 14, 2023
b3b688d
fuzz in CI
addisoncrump Jun 28, 2023
7b5bd6c
rename task for clarity
addisoncrump Jun 28, 2023
f4dfc87
fixup: updates affected fuzzers missed
addisoncrump Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: updates affected fuzzers missed
  • Loading branch information
@addisoncrump
addisoncrump committed Jun 28, 2023
commit f4dfc8779b3dbf3dfd4e38d794f14c0f1b8ab615
8 changes: 4 additions & 4 deletions fuzz/fuzz_targets/rome_common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use rome_formatter::format_node;
use rome_js_analyze::analyze;
use rome_js_formatter::context::JsFormatOptions;
use rome_js_formatter::JsFormatLanguage;
use rome_js_parser::parse;
use rome_js_parser::{JsParserOptions, parse};
use rome_js_syntax::JsFileSource;
use rome_json_formatter::context::JsonFormatOptions;
use rome_json_formatter::JsonFormatLanguage;
Expand All @@ -23,7 +23,7 @@ use std::sync::OnceLock;
pub fn fuzz_js_parser_with_source_type(data: &[u8], source: JsFileSource) -> Corpus {
let Ok(code1) = std::str::from_utf8(data) else { return Corpus::Reject; };

let parse1 = parse(code1, source);
let parse1 = parse(code1, source, JsParserOptions::default());
if !parse1.has_errors() {
let syntax1 = parse1.syntax();
let code2 = syntax1.to_string();
Expand Down Expand Up @@ -70,7 +70,7 @@ pub fn fuzz_js_formatter_with_source_type(data: &[u8], source: JsFileSource) ->
let rule_filters = ANALYSIS_RULE_FILTERS
.get_or_init(|| rules.as_enabled_rules().into_iter().collect::<Vec<_>>());

let parse1 = parse(code1, source);
let parse1 = parse(code1, source, JsParserOptions::default());
if !parse1.has_errors() {
let language = JsFormatLanguage::new(JsFormatOptions::new(source));
let tree1 = parse1.tree();
Expand All @@ -97,7 +97,7 @@ pub fn fuzz_js_formatter_with_source_type(data: &[u8], source: JsFileSource) ->
if let Ok(formatted1) = format_node(&syntax1, language.clone()) {
if let Ok(printed1) = formatted1.print() {
let code2 = printed1.as_code();
let parse2 = parse(code2, source);
let parse2 = parse(code2, source, JsParserOptions::default());
assert!(
!parse2.has_errors(),
"formatter introduced errors:\n{}",
Expand Down