Skip to content

Fix flaky shared flow subscription (Test) #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix flaky shared flow subscription (Test) #4488

wants to merge 2 commits into from

Conversation

murfel
Copy link
Contributor

@murfel murfel commented Jul 25, 2025

@murfel murfel requested a review from dkhalanskyjb July 25, 2025 14:22
@murfel murfel self-assigned this Jul 25, 2025
@murfel murfel changed the base branch from master to develop July 25, 2025 14:23
dkhalanskyjb
dkhalanskyjb suggested changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, though with expect/finish in place, var subscribed is excessive: expect(4) will fail anyway if not preceded by an expect(3).

@murfel murfel mentioned this pull request Jul 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dkhalanskyjb dkhalanskyjb dkhalanskyjb requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@murfel murfel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murfel @dkhalanskyjb