Skip to content

tests: properly test Isomorphic #6259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 3, 2025
Merged

tests: properly test Isomorphic #6259

merged 7 commits into from
Jun 3, 2025

Conversation

raveendra11
Copy link
Contributor

@raveendra11 raveendra11 commented Jun 3, 2025 •
edited by vil02
Loading

Fixes #6258

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.05%. Comparing base (b3c2c7a) to head (afaa9e4).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6259      +/-   ##
============================================
+ Coverage     73.98%   74.05%   +0.06%     
- Complexity     5346     5352       +6     
============================================
  Files           677      677              
  Lines         18652    18652              
  Branches       3621     3621              
============================================
+ Hits          13800    13813      +13     
+ Misses         4294     4281      -13     
  Partials        558      558

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

vil02
vil02 requested changes Jun 3, 2025
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I made some minor comments, which could be resolved quickly. Afterwards this can be merged.

@vil02 vil02 changed the title [#6258][BUG] Tests of Isomorphic tests: properly test Isomorphic Jun 3, 2025
@vil02 vil02 mentioned this pull request Jun 3, 2025
Closed
raveendra11 and others added 3 commits June 3, 2025 16:48
@raveendra11 @vil02
Update src/test/java/com/thealgorithms/strings/IsomorphicTest.java
78ed74d 
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
@raveendra11 @vil02
Update src/test/java/com/thealgorithms/strings/IsomorphicTest.java
af5e191 
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
@raveendra11
method name changed to inputs
afaa9e4
@raveendra11 raveendra11 requested a review from vil02 June 3, 2025 22:08
vil02
vil02 approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vil02 vil02 merged commit e123ca1 into TheAlgorithms:master Jun 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vil02 vil02 vil02 approved these changes

@DenizAltunkapan DenizAltunkapan Awaiting requested review from DenizAltunkapan DenizAltunkapan is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

@siriak siriak Awaiting requested review from siriak siriak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Tests of Isomorphic
3 participants
@raveendra11 @codecov-commenter @vil02