build: add a noDuplicateEnumValue rule #63483
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
approved these changes
Aug 29, 2025
f2246c3 to
f7ce8ba
Compare
It caught several legitimate issues. In the cases I wasn't sure, I just disabled the rule. fixes angular#45843
f7ce8ba to
b18990c
Compare
|
I think the diff is a bit self explantory, it's not the first time we have colliding Error codes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It caught several legitimate issues.
In the cases I wasn't sure, I just disabled the rule.
fixes #45843