Skip to content

build: add a noDuplicateEnumValue rule #63483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: add a noDuplicateEnumValue rule #63483

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

It caught several legitimate issues.
In the cases I wasn't sure, I just disabled the rule.

fixes #45843

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 29, 2025
@JeanMeche JeanMeche requested a review from mmalerba August 29, 2025 16:04
@ngbot ngbot bot added this to the Backlog milestone Aug 29, 2025
@JeanMeche JeanMeche mentioned this pull request Aug 29, 2025
Closed
josephperrott
josephperrott approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can we add some documentation somewhere of why this is not desirable? It seems like in some situations that duplicate enum values could be very useful.

@JeanMeche JeanMeche force-pushed the noduplicate-enum branch 2 times, most recently from f2246c3 to f7ce8ba Compare August 29, 2025 16:31
@JeanMeche
build: add a noDuplicateEnumValue rule
b18990c 
It caught several legitimate issues.
In the cases I wasn't sure, I just disabled the rule.

fixes angular#45843
@pullapprove pullapprove bot requested review from atscott and kirjs August 29, 2025 16:51
@JeanMeche
Copy link
Member Author

I think the diff is a bit self explantory, it's not the first time we have colliding Error codes.

kirjs
kirjs approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

packages/common/src/errors.ts
MISSING_EXTRA_LOCALE_DATA_FOR_LOCALE = 2303,
LOCALE_DATA_UNDEFINED = 2304,
INVALID_INTEGER_LITERAL = 2305,
INVALID_DIGIT_INFO = 2306,
INVALID_NUMBER_OF_DIGITS_AFTER_FRACTION = 2307,
NO_PLURAL_MESSAGE_FOUND = 2308,
VALUE_NOT_A_NUMBER = 2309,
UNKNOWN_ZONE_WIDTH = 2310,
INVALID_TO_DATE_CONVERSION = 2311,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@pullapprove pullapprove bot requested a review from AndrewKushnir September 2, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirjs kirjs kirjs approved these changes

@josephperrott josephperrott josephperrott approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@atscott atscott Awaiting requested review from atscott

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

Assignees
No one assigned
Labels
area: build & ci Related the build and CI infrastructure of the project
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Enable the no-duplicate-enum-values TSLint rule for the FW repo
3 participants
@JeanMeche @kirjs @josephperrott