forked from robotframework/SeleniumLibrary
-
Notifications
You must be signed in to change notification settings - Fork 0
Moved 'Element Should and Should Not Contain' test and updated CHANGES.rst #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emanlove
wants to merge
29
commits into
cheezy:master
Choose a base branch
from
emanlove:thats-cheezy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… first keyword -> indexes increase by one)
…sts can still be run in that env
…pip in install documentation
…ame>, using _element_find(). Added fix for _page_contains which will search both <frame> and <iframe> elements. But this fix for _page_contains needs a test first which is why the fix is currently commented out.
…rames and iframes. Currently iframe is failing as expected since patch has not been applied. Added test demonstrating how with the removal of the 'frame' tag from element searches could result in a "NoSuchFrameException" error if multiple elements have the same name attribute. Also demonstrated is how one can use xpath to search for either frame or iframe or both in such a case as a work around.
…rch both <frame> and <iframe> elements.
Add iframe support
couple typos; logLevel should be loglevel and locator attribute_locator
… test suite to content_assertions.txt test suite. Updated CHANGES.rst.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jeff,
I went ahead and moved the test over to content_assertions.txt and updated the change log (which when I fetch rtomac/master brought in all these other changes which should be ignored when merged back into rtomac/master on your pull request).
Ed