Skip to content

test(codersdk/toolsdk): skip coder_workspace_bash tool test on windows #19351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

test(codersdk/toolsdk): skip coder_workspace_bash tool test on windows #19351

merged 1 commit into from
Aug 14, 2025
+4 −0

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Aug 14, 2025 •
edited
Loading

Fixes flakes on the nightly-gauntlet like:
https://github.com/coder/coder/actions/runs/16955654896
since there's no bash on windows...

=== Failed
=== FAIL: codersdk/toolsdk  (0.00s)
PASS
The following tools were not tested:
 - coder_workspace_bash
Please ensure that all tools are tested using testTool().
If you just added a new tool, please add a test for it.
NOTE: if you just ran an individual test, this is expected.
FAIL	github.com/coder/coder/v2/codersdk/toolsdk	4.185s

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review August 14, 2025 04:54
@ethanndickson ethanndickson force-pushed the ethan/skip-bash-tool-windows branch from 69e047c to 7552890 Compare August 14, 2025 04:55
@ethanndickson ethanndickson merged commit b2b3edf into main Aug 14, 2025
36 checks passed
@ethanndickson ethanndickson deleted the ethan/skip-bash-tool-windows branch August 14, 2025 05:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @deansheather