Update the text input team's issue triage query #173999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
The pull request correctly updates the issue triage query for the text input team to be more accurate. This is a great improvement. I've added one suggestion to further refine the query by adding sorting and filtering parameters to align it with the queries used by most other teams in the document. This should help improve the triage process's consistency and effectiveness.
| @@ -291,7 +291,7 @@ PRs are reviewed weekly across the framework, packages, and engine repositories: | |||
|
|
|||
| - [P0 list](https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22a%3A+text+input%22%2Cteam-text-input%2Cfyi-text-input+sort%3Aupdated-asc+label%3AP0+) | |||
| - [PR list](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+sort%3Acreated-desc+draft%3Afalse+label%3A%22a%3A+text+input%22%2Cteam-text-input%2Cfyi-text-input+) | |||
| - [Incoming issue list](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22a%3A+text+input%22%2Cteam-text-input%2Cfyi-text-input+no%3Aassignee+-label%3A%22triaged-design%22+-label%3A%22triaged-framework%22+-label%3A%22triaged-linux%22+-label%3A%22triaged-macos%22+-label%3A%22triaged-windows%22+-label%3A%22triaged-android%22+-label%3A%22triaged-ios%22+-label%3A%22triaged-web%22+-label%3A%22triaged-ecosystem%22+-label%3A%22triaged-engine%22+-label%3A%22triaged-tool%22+-label%3A%22triaged-text-input%22+-project%3Aflutter%2F111+) | |||
| - [Incoming issue list](https://github.com/flutter/flutter/issues?q=is%3Aopen%20is%3Aissue%20label%3Ateam-text-input%2Cfyi-text-input%20no%3Aassignee%20-label%3Atriaged-text-input) | |||
There was a problem hiding this comment.
This new query is a great improvement! For consistency with most other teams and to potentially improve the triage process, consider a couple of adjustments:
- Add sorting and filtering: Including
sort:updated-ascwill sort the oldest issues first, which is a common and effective triage strategy. Adding-label:"will need additional triage"will filter out issues that are meant for the separate "critical triage" meeting, as described in this document. Most other teams' "Incoming issue list" queries include these parameters. - URL encoding: The current URL contains spaces, which can be problematic. For consistency with other links in this file, it's better to use
+to encode spaces.
Here is a suggested update that incorporates these changes:
Suggested change
| - [Incoming issue list](https://github.com/flutter/flutter/issues?q=is%3Aopen%20is%3Aissue%20label%3Ateam-text-input%2Cfyi-text-input%20no%3Aassignee%20-label%3Atriaged-text-input) | |
| - [Incoming issue list](https://github.com/flutter/flutter/issues?q=is:issue+is:open+label:team-text-input,fyi-text-input+no:assignee+-label:triaged-text-input+-label:"will need additional triage"+sort:updated-asc) |
justinmc
approved these changes
Aug 20, 2025
Not at all! I think looking at all untriaged issues regardless of which team the issue is assigned to would be the ideal workflow. It's unfortunate we can't have a query to do that easily! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 21, 2025
flutter/flutter@960d107...d2ac021 2025-08-21 mdebbar@google.com [web] Delete unused utils (flutter/flutter#174160) 2025-08-21 sstrickl@google.com Directly generate a Mach-O dynamic library using gen_snapshot. (flutter/flutter#171626) 2025-08-21 737941+loic-sharma@users.noreply.github.com Update the text input team's issue triage query (flutter/flutter#173999) 2025-08-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from V1A1J6uXZ62Q10i9u... to Z-ZaFQ7jAqJ1OrIBf... (flutter/flutter#174170) 2025-08-21 codefu@google.com whitespace (flutter/flutter#174210) 2025-08-21 magder@google.com Add review agent style guidelines to .gemini/styleguide.md (flutter/flutter#174000) 2025-08-20 matanlurey@users.noreply.github.com Move `Linux coverage` back to bringup (flutter/flutter#174171) 2025-08-20 rmacnak@google.com Engine build setup for Android RISCV64. (flutter/flutter#173672) 2025-08-20 41930132+hellohuanlin@users.noreply.github.com [ios][tools] do not print out bonjour key not found in non-verbose mode (flutter/flutter#174001) 2025-08-20 ahmedsameha1@gmail.com Make sure that an Autocomplete doesn't crash in 0x0 environment (flutter/flutter#172732) 2025-08-20 32538273+ValentinVignal@users.noreply.github.com Migrate some files to use `WidgetStateProperty` (flutter/flutter#174109) 2025-08-20 120297255+PurplePolyhedron@users.noreply.github.com Fix `onSelect` called twice in `DropdownMenuFormField` (flutter/flutter#174053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to. Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet. ### Motivation The text input team missed July's triage process self-test: flutter#171486. The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (flutter#171486) or `fyi-text-input` issues that another team marked as triaged.
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to. Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet. ### Motivation The text input team missed July's triage process self-test: flutter#171486. The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (flutter#171486) or `fyi-text-input` issues that another team marked as triaged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to.
Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet.
Motivation
The text input team missed July's triage process self-test: #171486.
The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (#171486) or
fyi-text-inputissues that another team marked as triaged.