[ios][tools] do not print out bonjour key not found in non-verbose mode #174001

hellohuanlin · 2025-08-18T23:32:14Z

This tries #173569 again

That PR was reverted, because I didn't know that streamOutput was the one used during non-verbose mode

The logging logic is a bit convoluted, see: #173887

So this PR simply changes the condition from

if (!verbose && exitCode == 0)

To

if (!verbose && exitCode == 0 && !skipErrorLog)

So that if we skipErrorLog (will be true for bonjour features), it doesn't call streamOutput.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

Fixes #172627

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

hellohuanlin · 2025-08-19T20:00:37Z

packages/flutter_tools/test/integration.shard/xcode_backend_test.dart

+            expect(pipe.readAsStringSync(), isNot(contains(plutilErrorMessage)));
+            expect(result.stderr, isNot(contains(plutilErrorMessage)));
+            if (verbose) {
+              expect(result.stdout, contains(plutilErrorMessage));


Verified consistent behavior on macOS 26 and 15.6:

On macOS 26:

if verbose, plutil logs to its stderr, and we redirect to stdout

if non-verbose, plutil logs to its stderr, and we ignore it

On macOS 15.6

if verbose, plutil logs to its stdout, and we simply log it to current process's stdout

if non-verbose, plutil logs to its stdout and we ignore it.

…de (flutter#174001)  This tries flutter#173569 again That PR was reverted, because I didn't know that `streamOutput` was the one used during non-verbose mode The logging logic is a bit convoluted, see: flutter#173887 So this PR simply changes the condition from ``` if (!verbose && exitCode == 0) ``` To ``` if (!verbose && exitCode == 0 && !skipErrorLog) ``` So that if we skipErrorLog (will be true for bonjour features), it doesn't call `streamOutput`. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Fixes flutter#172627 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…verbose mode (flutter/flutter#174001)

flutter/flutter@960d107...d2ac021 2025-08-21 mdebbar@google.com [web] Delete unused utils (flutter/flutter#174160) 2025-08-21 sstrickl@google.com Directly generate a Mach-O dynamic library using gen_snapshot. (flutter/flutter#171626) 2025-08-21 737941+loic-sharma@users.noreply.github.com Update the text input team's issue triage query (flutter/flutter#173999) 2025-08-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from V1A1J6uXZ62Q10i9u... to Z-ZaFQ7jAqJ1OrIBf... (flutter/flutter#174170) 2025-08-21 codefu@google.com whitespace (flutter/flutter#174210) 2025-08-21 magder@google.com Add review agent style guidelines to .gemini/styleguide.md (flutter/flutter#174000) 2025-08-20 matanlurey@users.noreply.github.com Move `Linux coverage` back to bringup (flutter/flutter#174171) 2025-08-20 rmacnak@google.com Engine build setup for Android RISCV64. (flutter/flutter#173672) 2025-08-20 41930132+hellohuanlin@users.noreply.github.com [ios][tools] do not print out bonjour key not found in non-verbose mode (flutter/flutter#174001) 2025-08-20 ahmedsameha1@gmail.com Make sure that an Autocomplete doesn't crash in 0x0 environment (flutter/flutter#172732) 2025-08-20 32538273+ValentinVignal@users.noreply.github.com Migrate some files to use `WidgetStateProperty` (flutter/flutter#174109) 2025-08-20 120297255+PurplePolyhedron@users.noreply.github.com Fix `onSelect` called twice in `DropdownMenuFormField` (flutter/flutter#174053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…de (flutter#174001)  This tries flutter#173569 again That PR was reverted, because I didn't know that `streamOutput` was the one used during non-verbose mode The logging logic is a bit convoluted, see: flutter#173887 So this PR simply changes the condition from ``` if (!verbose && exitCode == 0) ``` To ``` if (!verbose && exitCode == 0 && !skipErrorLog) ``` So that if we skipErrorLog (will be true for bonjour features), it doesn't call `streamOutput`. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Fixes flutter#172627 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Aug 18, 2025

hellohuanlin mentioned this pull request Aug 19, 2025

[Xcode 26 beta 4] Xcode reports Could not extract value, error: No value at that key path or invalid key path for some keys when running on iOS #172627

Closed

[ios][tool]do not log bonjour error in non-verbose mode

ba88a2c

hellohuanlin force-pushed the bonjour_log_try_again branch from bbb4ce2 to ba88a2c Compare August 19, 2025 19:52

hellohuanlin commented Aug 19, 2025

View reviewed changes

hellohuanlin marked this pull request as ready for review August 19, 2025 20:01

hellohuanlin requested a review from a team as a code owner August 19, 2025 20:01

hellohuanlin requested review from jmagman and vashworth August 19, 2025 20:01

vashworth approved these changes Aug 19, 2025

View reviewed changes

hellohuanlin added 2 commits August 20, 2025 11:24

Merge branch 'master' into bonjour_log_try_again

6a69970

Merge branch 'master' into bonjour_log_try_again

adad991

hellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025

auto-submit bot added this pull request to the merge queue Aug 20, 2025

Merged via the queue into flutter:master with commit 70aea54 Aug 20, 2025
146 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025

hellohuanlin added cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch labels Aug 21, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025

70aea543b [ios][tools] do not print out bonjour key not found in non-…

b04e557

…verbose mode (flutter/flutter#174001)

engine-flutter-autoroll mentioned this pull request Aug 21, 2025

Roll Flutter from 960d1078f876 to 38db233f4ff2 (8 revisions) flutter/packages#9863

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025

70aea543b [ios][tools] do not print out bonjour key not found in non-…

5cd057e

…verbose mode (flutter/flutter#174001)

engine-flutter-autoroll mentioned this pull request Aug 21, 2025

Roll Flutter from 960d1078f876 to 6ddbb81a22cd (9 revisions) flutter/packages#9864

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025

70aea543b [ios][tools] do not print out bonjour key not found in non-…

aceefcc

…verbose mode (flutter/flutter#174001)

engine-flutter-autoroll mentioned this pull request Aug 21, 2025

Roll Flutter from 960d1078f876 to 9330d4a7162c (10 revisions) flutter/packages#9865

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025

70aea543b [ios][tools] do not print out bonjour key not found in non-…

55afadc

…verbose mode (flutter/flutter#174001)

engine-flutter-autoroll mentioned this pull request Aug 21, 2025

Roll Flutter from 960d1078f876 to d2ac0210ee05 (12 revisions) flutter/packages#9866

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ios][tools] do not print out bonjour key not found in non-verbose mode #174001

[ios][tools] do not print out bonjour key not found in non-verbose mode #174001

hellohuanlin commented Aug 18, 2025 •

edited

Loading

Uh oh!

hellohuanlin Aug 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[ios][tools] do not print out bonjour key not found in non-verbose mode #174001

[ios][tools] do not print out bonjour key not found in non-verbose mode #174001

Conversation

hellohuanlin commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

hellohuanlin Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hellohuanlin commented Aug 18, 2025 •

edited

Loading

hellohuanlin Aug 19, 2025 •

edited

Loading