Test pyflyby on CI as a downstream project #14957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyflybyincludes an extension to IPython which integrates tightly with a substantial part of the IPython API.Previous IPython releases broke
pyflybyfunctionality; this may be acceptable if it happens in major releases, but there were instances were minor releases introduced incompatibilities which lead to downstream breakages.This PR includes a single
pyflybytest file that verifies the IPython-related integration in the downstream testing job. This is meant to serve as a canary test for breaking API changes in the completer, interactive help, and debug magics, all covered in thepyflybytest suite.Should we decide that this is no longer needed, or that it introduces too much noise, this PR could be reverted in the future, but as of now it makes releasing new versions much easier as it alleviates the worry about breaking downstream functionality.
Before merging deshaw/pyflyby#398:
After: