-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
increase sqs message size limit to 1MiB #12957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Hey @SethPyle376 👋 Thanks for the PR! It looks like the snapshots didn't include corresponding AWS validations. Did you manually edit these or run and record your test output against AWS? You can see some guides on how we write tests for our local emulator and maintain parity with AWS in the testing docs. In particular, I'd look at the parity testing docs. Since this PR will definitely require re-recording AWS behaviour, I'll just run the necessary snapshot tests against AWS and update your feature branch with the corrected files. You'll retain full authorship of the PR since we squash commits anyway. Does that work for you? 🙂 cc @baermat |
@gregfurman that sounds great and would be much appreciated. Thanks! |
4c45245
to
744a769
Compare
FYI i added the webserver configuration needed to make this change work. specifically we needed to increase the default limit for form-encoded requests. relevant code in werkzeug that lead to errors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @SethPyle376, and thanks for running the tests @gregfurman! The change turned out a little trickier than it seemed on the surface, but with the additional update of the form parser memory limit we should be good to go!
Motivation
This increases the SQS message and batch size limit to reflect the change AWS recently made. https://aws.amazon.com/about-aws/whats-new/2025/08/amazon-sqs-max-payload-size-1mib/
fixes #12956
Changes
Increases the size limit for SQS messages.