Skip to content

Conversation

SethPyle376
Copy link
Contributor

Motivation

This increases the SQS message and batch size limit to reflect the change AWS recently made. https://aws.amazon.com/about-aws/whats-new/2025/08/amazon-sqs-max-payload-size-1mib/

fixes #12956

Changes

Increases the size limit for SQS messages.

Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Contributor

localstack-bot commented Aug 5, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@SethPyle376
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Aug 5, 2025
@thrau thrau added the semver: patch Non-breaking changes which can be included in patch releases label Aug 5, 2025
@baermat baermat self-assigned this Aug 12, 2025
@gregfurman
Copy link
Contributor

gregfurman commented Aug 15, 2025

Hey @SethPyle376 👋 Thanks for the PR! It looks like the snapshots didn't include corresponding AWS validations. Did you manually edit these or run and record your test output against AWS?

You can see some guides on how we write tests for our local emulator and maintain parity with AWS in the testing docs. In particular, I'd look at the parity testing docs.

Since this PR will definitely require re-recording AWS behaviour, I'll just run the necessary snapshot tests against AWS and update your feature branch with the corrected files. You'll retain full authorship of the PR since we squash commits anyway. Does that work for you? 🙂

cc @baermat

@SethPyle376
Copy link
Contributor Author

@gregfurman that sounds great and would be much appreciated. Thanks!

@gregfurman gregfurman force-pushed the sqs-size-limit-increase branch from 4c45245 to 744a769 Compare August 20, 2025 15:48
@thrau
Copy link
Member

thrau commented Aug 26, 2025

FYI i added the webserver configuration needed to make this change work. specifically we needed to increase the default limit for form-encoded requests. relevant code in werkzeug that lead to errors:

@thrau thrau added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases skip-docs Pull request does not require documentation changes and removed semver: patch Non-breaking changes which can be included in patch releases labels Aug 26, 2025
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @SethPyle376, and thanks for running the tests @gregfurman! The change turned out a little trickier than it seemed on the surface, but with the additional update of the form parser memory limit we should be good to go!

@thrau thrau merged commit f49d418 into localstack:main Aug 26, 2025
41 of 44 checks passed
dfangl added a commit that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases skip-docs Pull request does not require documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: SQS messages larger than 256KiB are rejected
5 participants