ports: make naming of ROMFS partition config variables consistent #16903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iabdalkader FYI |
|
Code size report: |
|
This is much better, thanks! Note, this PR will have to be updated or merged first #16869 |
Change ROMFS partition configuration variables to use index 0 as the starting partition number (instead of index 1). Reasons to do this: - `vfs.rom_ioctl()` numbers the partitions starting from 0 - `mpremote romfs -p <partition id>` numbers the partitions starting from 0 Signed-off-by: Damien George <damien@micropython.org>
For consistency with the stm32 port. Signed-off-by: Damien George <damien@micropython.org>
6105f50 to
d5aeca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change ROMFS partition configuration variables to be more consistent across the ports, and use index 0 as the starting partition number (instead of index 1).
Reason:
vfs.rom_ioctl()numbers the partitions starting from 0mpremote romfs -p <partition id>numbers the partitions starting from 0Testing
CI should test this, building the boards that enable ROMFS on stm32 and esp8266.