Skip to content

cpydiff: Document complex() parsing difference. #17470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Jun 10, 2025

Summary

In #17384 it was decided that fixing this difference was not worth the code size increase.

Testing

Built & viewed the documentation locally
image

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (2ce63b1) to head (9527fa0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #17470   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         169      169           
  Lines       21941    21941           
=======================================
  Hits        21621    21621           
  Misses        320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

In micropython#17384 it was
decided that fixing this difference was not worth the code size
increase.

Signed-off-by: Jeff Epler <jepler@gmail.com>
@jepler jepler force-pushed the document-complex-function-difference branch from 235b774 to 9527fa0 Compare June 10, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant