BLD: update licensing metadata to use PEP 639 #29535
Merged
+78
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
commented
Aug 9, 2025
9ffbf88 to
d77b06a
Compare
d77b06a to
bd0fc29
Compare
|
LGTM AFAICT, I'm not familiar with the details of PEP 639, and it looks quite involved. |
bd0fc29 to
0f39fd2
Compare
|
This is good to go now. Tested wheel builds as well on my fork, logs here. |
|
I downloaded and inspected a wheel built on the fork. It has (as expected) an additional |
|
No nothing else to look at that I can think of. |
|
Thanks @rgommers |
This was referenced Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review; opened as Draft because I need to check if anything changes in wheel builds related to this.