Skip to content

📖 Use --strict for mkdocs build/deploy #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Aug 21, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@anik120 anik120 requested a review from a team as a code owner August 21, 2025 17:57
Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1d88f3b
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68a75e18cf16dd0008b2a74b
😎 Deploy Preview https://deploy-preview-2157--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anik120 anik120 requested review from grokspawn and removed request for rashmigottipati and thetechnick August 21, 2025 17:59
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.73%. Comparing base (07bd008) to head (1d88f3b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
- Coverage   72.75%   72.73%   -0.02%     
==========================================
  Files          79       79              
  Lines        7340     7340              
==========================================
- Hits         5340     5339       -1     
- Misses       1653     1654       +1     
  Partials      347      347              
Flag Coverage Δ
e2e 44.34% <ø> (ø)
experimental-e2e 54.91% <ø> (-0.05%) ⬇️
unit 58.22% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -31,7 +31,7 @@ As an example, to access only the [package schema](https://olm.operatorframework

the URL to access the service would be `https://catalogd-service.olmv1-system.svc/catalogs/operatorhubio/api/v1/metas?schema=olm.package`

For more examples of valid queries that can be made to the `api/v1/metas` service endpoint, please see [Catalog Queries](../howto/catalog-queries.md).
For more examples of valid queries that can be made to the `api/v1/metas` service endpoint, please see [Catalog Queries](../../howto/catalog-queries.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that these are in the docs/draft folder, and will be moved to the docs directory, I don't we need the extra directory level; it will all work out when it's moved out of drafts.

Same with the other two directory level changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants