📖 Use --strict for mkdocs build/deploy #2157
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2157 +/- ##
==========================================
- Coverage 72.75% 72.73% -0.02%
==========================================
Files 79 79
Lines 7340 7340
==========================================
- Hits 5340 5339 -1
- Misses 1653 1654 +1
Partials 347 347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -31,7 +31,7 @@ As an example, to access only the [package schema](https://olm.operatorframework | |||
|
|
|||
| the URL to access the service would be `https://catalogd-service.olmv1-system.svc/catalogs/operatorhubio/api/v1/metas?schema=olm.package` | |||
|
|
|||
| For more examples of valid queries that can be made to the `api/v1/metas` service endpoint, please see [Catalog Queries](../howto/catalog-queries.md). | |||
| For more examples of valid queries that can be made to the `api/v1/metas` service endpoint, please see [Catalog Queries](../../howto/catalog-queries.md). | |||
There was a problem hiding this comment.
Given that these are in the docs/draft folder, and will be moved to the docs directory, I don't we need the extra directory level; it will all work out when it's moved out of drafts.
Same with the other two directory level changes.
There was a problem hiding this comment.
Right, but then current --strict restrictions will throw up warning which will cause CI to fail.
If we move forward with the current configuration, when the docs are moved out of draft, there will again be another failed CI event, which will highlight that the links need to be updated.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f7d962b
into
operator-framework:main
Description
Reviewer Checklist