Skip to content

[FSSDK-11172] feat: update decision service to handle CMAB #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 14, 2025
Merged

[FSSDK-11172] feat: update decision service to handle CMAB #602

merged 26 commits into from
Jul 14, 2025
+1,997 −156

Conversation

muzahidul-opti
Copy link
Contributor

Summary

  • Update decision service to handle CMAB
  • Add async support for decide apis
  • Refractor default bucketer to handle CMAB traffic allocation

Test plan

Issues

  • FSSDK-11172

@muzahidul-opti
wip: cmab client done
b40adda
@muzahidul-opti
Update test cases
9c9b9b0
@muzahidul-opti
wip: add test cases for cmab services
d998e0b
@muzahidul-opti
Merge branch 'master' into muzahid/cmab-service
c427a46 
# Conflicts:
#	OptimizelySwiftSDK.xcodeproj/project.pbxproj
#	Sources/CMAB/CmabClient.swift
#	Tests/OptimizelyTests-Common/CMABClientTests.swift
@muzahidul-opti
Added log for cmab decision
8e168f6
@muzahidul-opti
Update copyright date
0c4d072
@muzahidul-opti
CMAB decision implemented
f342ae2
@muzahidul-opti
CmabService testcases added for sync getDecision function
ebbde3c
@muzahidul-opti
Add factory method for DefaultCmabService
92d3140
@muzahidul-opti
DefaultDecision initializer updated
c6507b0
@muzahidul-opti
Add operation type enum
b51c228
@muzahidul-opti
CMAB not supported in sync mode
e9d01ac
@muzahidul-opti
Reuse experiment bucketing logic
e827b27
@muzahidul-opti
Add seperate method for group exlusion, add bucketToEntityId method
445006b
@muzahidul-opti
Update bucketing logic for cmab experiment
b9ce0f5
@muzahidul-opti
Add test cases for cmab experiement
093e372
@muzahidul-opti muzahidul-opti marked this pull request as ready for review July 2, 2025 12:05
@muzahidul-opti muzahidul-opti requested a review from raju-opti July 2, 2025 12:06
@muzahidul-opti
Merge branch 'master' into muzahid/cmab-decision
f0c1d5b 
# Conflicts:
#	Sources/CMAB/CmabService.swift
#	Tests/OptimizelyTests-Common/CmabServiceTests.swift
@muzahidul-opti
Add test cases for bucketToEntity
384bfa8
jaeopt
jaeopt requested changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I have a suggestion to clean up .opType passing down.
Let's discuss about the option.

@muzahidul-opti muzahidul-opti requested a review from jaeopt July 9, 2025 13:36
jaeopt
jaeopt requested changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! A couple of small changes.

@muzahidul-opti muzahidul-opti requested a review from jaeopt July 10, 2025 12:52
jaeopt
jaeopt approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 5baf45e into master Jul 14, 2025
9 of 12 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/cmab-decision branch July 14, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@raju-opti raju-opti Awaiting requested review from raju-opti

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt