-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
Mention the "context manager" keyword in concurrent.futures documentation #130976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention the "context manager" keyword in concurrent.futures documentation #130976
Conversation
…tion I was searching for context manager-related part part of this documentation and I couldn't find anything because the words "context manager" weren't actually used anywhere. I think this will help with discoverability of this feature.
There are more lines changed than strictly necessary because I maintained the overall line length in that section, let me know if I should do otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Thanks @jstasiak for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…tion (pythonGH-130976) (cherry picked from commit 095bc77) Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
…tion (pythonGH-130976) (cherry picked from commit 095bc77) Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
GH-137810 is a backport of this pull request to the 3.14 branch. |
GH-137811 is a backport of this pull request to the 3.13 branch. |
I was searching for context manager-related part part of this documentation and I couldn't find anything because the words "context manager" weren't actually used anywhere.
I think this will help with discoverability of this feature.
📚 Documentation preview 📚: https://cpython-previews--130976.org.readthedocs.build/