gh-134262: Catch both URLError and ConnectionError in retries #135365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
approved these changes
Jun 10, 2025
Comment on lines
+8
to
10
| import urllib.error | ||
| import zipfile | ||
| from urllib.request import urlretrieve |
There was a problem hiding this comment.
Suggested change
| import urllib.error | |
| import zipfile | |
| from urllib.request import urlretrieve | |
| import zipfile | |
| from urllib.error import URLError | |
| from urllib.request import urlretrieve |
Some people may prefer keeping them together?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@StanFromIreland pointed to this failure https://github.com/python/cpython/actions/runs/15565936921/job/43829935370?pr=135355 where we fail downloading without useful debug information because we are only catching URLError. We should probably catch both URLError and ConnectionError for both of these retries so that we retry on all connection failures.