Skip to content

gh-134262: Catch both URLError and ConnectionError in retries #135365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-134262: Catch both URLError and ConnectionError in retries #135365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2796bd1
Catch both URLError and ConnectionError in retries
emmatyping Jun 10, 2025
a22e591
Merge branch 'main' into catch-urlerror-and-connectionerror
emmatyping Jun 13, 2025
ffd6b95
Unify imports
emmatyping Jun 13, 2025
0255647
Merge branch 'catch-urlerror-and-connectionerror' of github.com:emmat…
emmatyping Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions PCbuild/get_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,22 @@
import pathlib
import sys
import time
import urllib.error
import urllib.request
import zipfile
from urllib.request import urlretrieve


def retrieve_with_retries(download_location, output_path, reporthook,
max_retries=7):
"""Download a file with exponential backoff retry and save to disk."""
for attempt in range(max_retries + 1):
try:
resp = urlretrieve(
resp = urllib.request.urlretrieve(
download_location,
output_path,
reporthook=reporthook,
)
except ConnectionError as ex:
except (urllib.error.URLError, ConnectionError) as ex:
if attempt == max_retries:
msg = f"Download from {download_location} failed."
raise OSError(msg) from ex
Expand Down
2 changes: 1 addition & 1 deletion Tools/build/generate_sbom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def download_with_retries(download_location: str,
for attempt in range(max_retries + 1):
try:
resp = urllib.request.urlopen(download_location)
except urllib.error.URLError as ex:
except (urllib.error.URLError, ConnectionError) as ex:
if attempt == max_retries:
msg = f"Download from {download_location} failed."
raise OSError(msg) from ex
Expand Down
Loading